Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564344

Re: [PATCH v2 3/3] clk: rockchip: rk3288: make all niu clocks critical

Show all headers | View raw

2017-01-18 13:42 GMT+08:00 Jacob Chen <jacob-chen@iotwrt.com>:
> NIU clocks are related to the interconnect and it's important to other blocks.
> Since we don't have a driver to handle it, we should always enable it to avoid
> casually close.
>
> Make all of them critical,so that we don't have to each clock on its own
> once things break.
>
> Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
> ---
>  drivers/clk/rockchip/clk-rk3288.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
> index 3d02aa2..c50386c 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -808,8 +808,15 @@ static struct rockchip_clk_branch rk3288_clk_branches[] __initdata = {
>  static const char *const rk3288_critical_clocks[] __initconst = {
>         "aclk_cpu",
>         "aclk_peri",
> +       "aclk_peri_niu",
> +       "aclk_vio0_niu",
> +       "aclk_vio1_niu",
> +       "aclk_rga_niu",
>         "hclk_peri",
> +       "hclk_vio_niu",
> +       "pclk_alive_niu",
>         "pclk_pd_pmu",
> +       "pclk_pmu_niu",
>  };
>
>  static void __iomem *rk3288_cru_base;
> --
> 2.7.4
>

I just got an another bug that caused by closed niu clock.
Making niu clock always enabled is really useful, it could save me a
lot of time.....

I just wonder why we don't do that before.  Would it have great impact
on power consumption?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/3] clk: rockchip: add rk3288 vip_out clock ids Jacob Chen <jacob-chen@iotwrt.com> - 2017-01-18 07:00 +0100
  [PATCH v2 3/3] clk: rockchip: rk3288: make all niu clocks critical Jacob Chen <jacob-chen@iotwrt.com> - 2017-01-18 07:00 +0100
    Re: [PATCH v2 3/3] clk: rockchip: rk3288: make all niu clocks critical Jacob Chen <jacobchen110@gmail.com> - 2017-01-22 10:10 +0100
      Re: [PATCH v2 3/3] clk: rockchip: rk3288: make all niu clocks critical Heiko Stuebner <heiko@sntech.de> - 2017-01-22 13:10 +0100
  Re: [PATCH v2 1/3] clk: rockchip: add rk3288 vip_out clock ids Heiko Stuebner <heiko@sntech.de> - 2017-01-23 01:30 +0100

csiph-web