Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1565255

[PATCH] pata_octeon_cf: remove unused local variables from octeon_cf_set_piomode()

From "tj@kernel.org" <tj@kernel.org>
Newsgroups linux.kernel
Subject [PATCH] pata_octeon_cf: remove unused local variables from octeon_cf_set_piomode()
Date 2017-01-23 20:40 +0100
Message-ID <t2SD7-237-3@gated-at.bofh.it> (permalink)
References <t2SD7-237-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From d786b91f422c6ad4c0d9bb9c1bef2dd5008e3d9d Mon Sep 17 00:00:00 2001
From: Tejun Heo <tj@kernel.org>
Date: Mon, 23 Jan 2017 14:28:51 -0500

@t1 and @t2i are calculated along with @t2 but never used.  Drop them.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: David Binderman <dcb314@hotmail.com>
---
Applied to libata/for-4.11.  Thanks.

 drivers/ata/pata_octeon_cf.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
index e94e7ca..f524a90 100644
--- a/drivers/ata/pata_octeon_cf.c
+++ b/drivers/ata/pata_octeon_cf.c
@@ -138,9 +138,7 @@ static void octeon_cf_set_piomode(struct ata_port *ap, struct ata_device *dev)
 	int trh;
 	int pause;
 	/* These names are timing parameters from the ATA spec */
-	int t1;
 	int t2;
-	int t2i;
 
 	/*
 	 * A divisor value of four will overflow the timing fields at
@@ -154,15 +152,9 @@ static void octeon_cf_set_piomode(struct ata_port *ap, struct ata_device *dev)
 
 	BUG_ON(ata_timing_compute(dev, dev->pio_mode, &timing, T, T));
 
-	t1 = timing.setup;
-	if (t1)
-		t1--;
 	t2 = timing.active;
 	if (t2)
 		t2--;
-	t2i = timing.act8b;
-	if (t2i)
-		t2i--;
 
 	trh = ns_to_tim_reg(div, 20);
 	if (trh)
-- 
2.9.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] pata_octeon_cf: remove unused local variables from  octeon_cf_set_piomode() "tj@kernel.org" <tj@kernel.org> - 2017-01-23 20:40 +0100

csiph-web