Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1565081

[PATCH v2 1/2] dt-bindings: arm,gic: Fix binding example for a virt-capable GIC

Show all headers | View raw

The joys of copy/paste: the example of a virtualization capable GIC
in the DT binding was wrong, and propagated to dozens of platforms.
By having a GICC region that is only 4kB (instead of 8kB), we
end-up not being able to access the GICC_DIR register which is on
the second page.

Oh well. Let's fix the source of the crap before tackling individual
offenders. While we're at it, also fix the compatibility string to
mention "arm,gic-400", which is the name of the actual implementation
of the GICv2 spec.

Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
 Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
index 5393e2a..a3d51ed 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/arm,gic.txt
@@ -107,11 +107,11 @@ Required properties:
 Example:
 
 	interrupt-controller@2c001000 {
-		compatible = "arm,cortex-a15-gic";
+		compatible = "arm,gic-400";
 		#interrupt-cells = <3>;
 		interrupt-controller;
 		reg = <0x2c001000 0x1000>,
-		      <0x2c002000 0x1000>,
+		      <0x2c002000 0x2000>,
 		      <0x2c004000 0x2000>,
 		      <0x2c006000 0x2000>;
 		interrupts = <1 9 0xf04>;
-- 
2.1.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/2] ARM: DTS: Fix broken GICv2 register maps Marc Zyngier <marc.zyngier@arm.com> - 2017-01-23 17:00 +0100
  [PATCH v2 1/2] dt-bindings: arm,gic: Fix binding example for a virt-capable GIC Marc Zyngier <marc.zyngier@arm.com> - 2017-01-23 17:00 +0100
    Re: [PATCH v2 1/2] dt-bindings: arm,gic: Fix binding example for a  virt-capable GIC Rob Herring <robh@kernel.org> - 2017-01-27 21:40 +0100
      Re: [PATCH v2 1/2] dt-bindings: arm,gic: Fix binding example for a  virt-capable GIC Olof Johansson <olof@lixom.net> - 2017-01-30 01:20 +0100
        Re: [PATCH v2 1/2] dt-bindings: arm,gic: Fix binding example for a  virt-capable GIC Marc Zyngier <marc.zyngier@arm.com> - 2017-01-30 10:00 +0100
  [PATCH v2 2/2] ARM: DTS: Fix register map for virt-capable GIC Marc Zyngier <marc.zyngier@arm.com> - 2017-01-23 17:00 +0100

csiph-web