Re: [PATCH 3/5] blk-throttle: Adjust two function calls together with a variable assignment

From	Jens Axboe <axboe@kernel.dk>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/5] blk-throttle: Adjust two function calls together with a variable assignment
Date	2017-01-23 16:20 +0100
Message-ID	<t2Ozx-84K-41@gated-at.bofh.it> (permalink)
References	<t2lQR-6Vp-9@gated-at.bofh.it> <t2lQS-6Vp-19@gated-at.bofh.it> <t2J6O-4DB-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/23/2017 02:20 AM, Johannes Thumshirn wrote:
> On Sun, Jan 22, 2017 at 09:33:08AM +0100, SF Markus Elfring wrote:
>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Sat, 21 Jan 2017 22:15:33 +0100
>>
>> The script "checkpatch.pl" pointed information out like the following.
>>
>> ERROR: do not use assignment in if condition
>>
>> Thus fix the affected source code places.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>> ---
> 
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> if Jens wants doesn't mind.

I don't mind these, but I completely agree on the patches for moving the
'error' assignment. What ends up happening for those cases is that
someone adds a new section and forgets to set 'error', and then all hell
breaks lose.

So Markus, don't bother sending those patches again for the block layer
or drivers, I'm not going to take them.

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] block: Fine-tuning for five function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-22 09:40 +0100
  [PATCH 4/5] cfq-iosched: Move an assignment for the variable "ret" in  __cfqg_set_weight_device() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-22 09:40 +0100
  [PATCH 3/5] blk-throttle: Adjust two function calls together with a  variable assignment SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-22 09:40 +0100
    Re: [PATCH 3/5] blk-throttle: Adjust two function calls together  with a variable assignment Johannes Thumshirn <jthumshirn@suse.de> - 2017-01-23 10:30 +0100
      Re: [PATCH 3/5] blk-throttle: Adjust two function calls together with  a variable assignment Jens Axboe <axboe@kernel.dk> - 2017-01-23 16:20 +0100

csiph-web