Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1565020

Re: [PATCH 1/2] device property: export code duplicating array of property entries

Show all headers | View raw

On Sun, 2017-01-22 at 23:38 -0800, Dmitry Torokhov wrote:
> When augmenting ACPI-enumerated devices with additional property data
> based
> on DMI info, a module has often several potential property sets, with
> only
> one being active on a given box. In order to save memory it should be
> possible to mark everything and __initdata or __initconst, execute DMI
> match early, and duplicate relevant properties. Then kernel will
> discard
> the rest of them.
> 

Looks good to me.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Couple of style nitpicks.

> 
> +struct property_entry *property_entries_dup(
> +				const struct property_entry
> *properties)

Can we use

struct propert_entry *
property_entries_dup(...)

?


> +struct property_entry *property_entries_dup(
> +				const struct property_entry
> *properties);
> 

Ditto.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] device property: export code duplicating array of property entries Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-23 08:40 +0100
  Re: [PATCH 1/2] device property: export code duplicating array of  property entries Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-01-23 15:40 +0100
  Re: [PATCH 1/2] device property: export code duplicating array of  property entries Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-23 16:10 +0100
    Re: [PATCH 1/2] device property: export code duplicating array of  property entries Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-23 23:50 +0100

csiph-web