Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1564919

Re: [PATCH] mfd: tps65912: Export OF device ID table as module aliases

From Lee Jones <lee.jones@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] mfd: tps65912: Export OF device ID table as module aliases
Date 2017-01-23 13:00 +0100
Message-ID <t2LrZ-5Y8-27@gated-at.bofh.it> (permalink)
References <t0gLE-1Gm-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 16 Jan 2017, Javier Martinez Canillas wrote:

> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
> 
> Before this patch:
> 
> $ modinfo drivers/mfd/tps65912-i2c.ko | grep alias
> alias:          i2c:tps65912
> 
> After this patch:
> 
> $ modinfo drivers/mfd/tps65912-i2c.ko | grep alias
> alias:          of:N*T*Cti,tps65912C*
> alias:          of:N*T*Cti,tps65912
> alias:          i2c:tps65912
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> 
>  drivers/mfd/tps65912-i2c.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/tps65912-i2c.c b/drivers/mfd/tps65912-i2c.c
> index 45871403f995..785d19f6f7c9 100644
> --- a/drivers/mfd/tps65912-i2c.c
> +++ b/drivers/mfd/tps65912-i2c.c
> @@ -27,6 +27,7 @@ static const struct of_device_id tps65912_i2c_of_match_table[] = {
>  	{ .compatible = "ti,tps65912", },
>  	{ /* sentinel */ }
>  };
> +MODULE_DEVICE_TABLE(of, tps65912_i2c_of_match_table);
>  
>  static int tps65912_i2c_probe(struct i2c_client *client,
>  			      const struct i2c_device_id *ids)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] mfd: tps65912: Export OF device ID table as module  aliases Lee Jones <lee.jones@linaro.org> - 2017-01-23 13:00 +0100

csiph-web