Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1564894

[PATCH 2/8] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()

From Roger Quadros <rogerq@ti.com>
Newsgroups linux.kernel
Subject [PATCH 2/8] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox()
Date 2017-01-23 12:30 +0100
Message-ID <t2KYX-5NX-31@gated-at.bofh.it> (permalink)
References <t2KYW-5NX-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


We need to break from all cases if we want to treat
each one of them separately.

Fixes: d2728fb3e01f ("usb: dwc3: omap: Pass VBUS and ID events transparently")
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/usb/dwc3/dwc3-omap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index eb1b9cb..35b6351 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -250,6 +250,7 @@ static void dwc3_omap_set_mailbox(struct dwc3_omap *omap,
 		val = dwc3_omap_read_utmi_ctrl(omap);
 		val |= USBOTGSS_UTMI_OTG_CTRL_IDDIG;
 		dwc3_omap_write_utmi_ctrl(omap, val);
+		break;
 
 	case OMAP_DWC3_VBUS_OFF:
 		val = dwc3_omap_read_utmi_ctrl(omap);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/8] usb: dwc3: add dual-role support Roger Quadros <rogerq@ti.com> - 2017-01-23 12:30 +0100
  [PATCH 5/8] usb: dwc3: add dual-role support Roger Quadros <rogerq@ti.com> - 2017-01-23 12:30 +0100
  [PATCH 4/8] usb: dwc3: core.h: add some register definitions Roger Quadros <rogerq@ti.com> - 2017-01-23 12:30 +0100
  [PATCH 2/8] usb: dwc3-omap: Fix missing break in dwc3_omap_set_mailbox() Roger Quadros <rogerq@ti.com> - 2017-01-23 12:30 +0100
  Re: [PATCH 0/8] usb: dwc3: add dual-role support Chanwoo Choi <cw00.choi@samsung.com> - 2017-01-23 12:50 +0100

csiph-web