Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564809

Re: [PATCH] KVM: s390: Move two error code assignments in kvm_vm_ioctl_get_dirty_log()

From Paolo Bonzini <pbonzini@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] KVM: s390: Move two error code assignments in kvm_vm_ioctl_get_dirty_log()
Date 2017-01-23 10:30 +0100
Message-ID <t2J6N-4DB-1@gated-at.bofh.it> (permalink)
References <t26oN-62y-7@gated-at.bofh.it> <t2IaJ-44k-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 23/01/2017 09:22, Christian Borntraeger wrote:
> Patches that changes open coded things to common helpers or things like
> kmalloc_array where appropriate or things that make the code more robust
> are fine and welcome, but I am not going to take this as it just shuffles
> things around. It does not fix anything and it does not improve the code,
> but it certainly carries the risk of breaking something (yes in this case
> it looks perfectly fine, though).

Besides,

	r = -ESOMETHING;
	if (...)
		return r;

is the way it's done everywhere else in KVM.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-21 17:10 +0100
  Re: [PATCH] KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() Christian Borntraeger <borntraeger@de.ibm.com> - 2017-01-23 09:30 +0100
    Re: [PATCH] KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() Paolo Bonzini <pbonzini@redhat.com> - 2017-01-23 10:30 +0100
    Re: KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-23 12:10 +0100
      Re: KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-23 13:30 +0100
        Re: KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-23 14:30 +0100
          Re: KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-23 14:40 +0100
      Re: KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() Christian Borntraeger <borntraeger@de.ibm.com> - 2017-01-23 14:40 +0100
        Re: KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() Paolo Bonzini <pbonzini@redhat.com> - 2017-01-24 13:20 +0100
          Re: KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() Christian Borntraeger <borntraeger@de.ibm.com> - 2017-01-24 13:40 +0100
            Re: KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-24 13:50 +0100
          Re: KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-24 13:40 +0100
        Re: KVM: s390: Move two error code assignments in  kvm_vm_ioctl_get_dirty_log() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-24 13:20 +0100

csiph-web