Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564795

Re: [PATCH 2/5] blk-throttle: Move an assignment for the variable "ret" in tg_set_conf()

Show all headers | View raw

On Sun, Jan 22, 2017 at 09:32:19AM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 21 Jan 2017 21:40:38 +0100
> 
> A local variable was set to an error code before a concrete error situation
> was detected. Thus move the corresponding assignment into an if branch
> to indicate a software failure there.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---

See my answer to the last patch.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/5] blk-throttle: Move an assignment for the variable "ret"  in tg_set_conf() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-22 09:40 +0100
  Re: [PATCH 2/5] blk-throttle: Move an assignment for the variable  "ret" in tg_set_conf() Johannes Thumshirn <jthumshirn@suse.de> - 2017-01-23 10:20 +0100

csiph-web