Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1564657

[PATCH v2 2/3] btmrvl: set irq_bt to -1 when failed to parse it

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Jeffy Chen <jeffy.chen@rock-chips.com>
Newsgroups linux.kernel
Subject [PATCH v2 2/3] btmrvl: set irq_bt to -1 when failed to parse it
Date Mon, 23 Jan 2017 05:20:02 +0100
Message-ID <t2EgO-1Ep-1@gated-at.bofh.it> (permalink)
References <t2EgO-1Ep-3@gated-at.bofh.it>
X-263anti-Spam KSV:0;
X-Mail-Delivery 1
X-Abs-Checked 4
X-Rl-Sender jeffy.chen@rock-chips.com
X-Fst-To linux-bluetooth@vger.kernel.org
X-Sender-IP 103.29.142.67
X-Login-Name jeffy.chen@rock-chips.com
X-Unique-Tag <e8634ddfd36be9737f652f2ebeef1b5a>
X-Sender cjf@rock-chips.com
X-Mailer git-send-email 2.1.4
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 29
Organization linux.* mail to news gateway
X-Original-Cc Amitkumar Karwar <akarwar@marvell.com>, Marcel Holtmann <marcel@holtmann.org>, Brian Norris <briannorris@chromium.org>, Jeffy Chen <jeffy.chen@rock-chips.com>, Johan Hedberg <johan.hedberg@gmail.com>, Gustavo Padovan <gustavo@padovan.org>, linux-kernel@vger.kernel.org
X-Original-Date Mon, 23 Jan 2017 12:18:52 +0800
X-Original-Message-ID <1485145133-8612-2-git-send-email-jeffy.chen@rock-chips.com>
X-Original-References <1485145133-8612-1-git-send-email-jeffy.chen@rock-chips.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1564657

Show key headers only | View raw


The irq_of_parse_and_map will return 0 as a invalid irq.

Set irq_bt to -1 in this case, so that the btmrvl resume/suspend code
would not try to enable/disable it.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Reviewed-by: Brian Norris <briannorris@chromium.org>
---

Changes in v2:
Update commit message.

 drivers/bluetooth/btmrvl_sdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index c738bae..796f719 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers/bluetooth/btmrvl_sdio.c
@@ -97,6 +97,7 @@ static int btmrvl_sdio_probe_of(struct device *dev,
 		cfg->irq_bt = irq_of_parse_and_map(card->plt_of_node, 0);
 		if (!cfg->irq_bt) {
 			dev_err(dev, "fail to parse irq_bt from device tree");
+			cfg->irq_bt = -1;
 		} else {
 			ret = devm_request_irq(dev, cfg->irq_bt,
 					       btmrvl_wake_irq_bt,
-- 
2.1.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH v2 2/3] btmrvl: set irq_bt to -1 when failed to parse it Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-01-23 05:20 +0100

csiph-web