Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1564221

[PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn

Path csiph.com!news.redatomik.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From Florian Fainelli <f.fainelli@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn
Date Sat, 21 Jan 2017 20:30:01 +0100
Message-ID <t29wl-7O2-9@gated-at.bofh.it> (permalink)
References <t29wl-7O2-7@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TQtt5IcSRn80h4d4cHAwmNckrEgbVrN+eSjqEXQUzZY=; b=BpoxQXcOn007+gko/hT3bz9etWhOx8bZTvl6MQjY27XFkb4/JQrh3OoxsvCRntYcyN 0L8zgO49ejYpbb3BCKtRRrhTFtngln1I69FlnGjND82n5+V66gASoN5LOjxvtm0XSWeB s73kjZQZJN8OOVmmtJjkHw0Pv5tdwChwxgCq/XamMo4zLwAmgPr/1ZZf4kBq93V6PxHI yixIiv8oDr9efuERihOPnKwUz75G9QsaioP3RGnDJwKMLq3P/KWT0zcHeG7Bk5TznRQO cTbnbwAtoaDE1k0G23di0fIYdOKjvt7GmNCRnbeRRu79ymhXZEVc60KLI6lnZ3TtuWvl 3dPw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TQtt5IcSRn80h4d4cHAwmNckrEgbVrN+eSjqEXQUzZY=; b=W7VX09pWZUuyofTQMHeRTKJfl2Gj0y+EfhlVqeLlayYRuRYPW41N4YYpSkBljojttD L12B7vb3UPJkdtOIOCEIpsjEyNjAfjyOWO9Mqidbke02qreflOtWWJVU9Cai3pw9eb4T zv019lf2MeASwRUs2vwxNm9U6jwT6cXmWEBWJa66TIg1OKOYeuNo1y651swjiaxdcwWX zH3VUcKRw2Kx2fy4rXL0lik6mzGhG0q4ct/RPdqRw3qKFFrcb9uEtOdJoP0Px2ub+ecS fZo0n/Hb0BYm+Bj96QtIWiYcmDYcI8DHhjWY1MyO5zVcVWH94Pgwukt9yBminFBPpcbt 5CKA==
X-Gm-Message-State AIkVDXKs0pt6d/DOlosTB/o/eEb9VPqeftFetbBOe14sK+hld+g+HB5afRxA42TiP4MrHg==
X-Received by 10.55.185.70 with SMTP id j67mr7986062qkf.4.1485026428248; Sat, 21 Jan 2017 11:20:28 -0800 (PST)
X-Mailer git-send-email 2.9.3
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 23
Organization linux.* mail to news gateway
X-Original-Cc Florian Fainelli <f.fainelli@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>, Jonathan Corbet <corbet@lwn.net>, devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-hwmon@vger.kernel.org (open list:HARDWARE MONITORING), linux-doc@vger.kernel.org (open list:DOCUMENTATION)
X-Original-Date Sat, 21 Jan 2017 11:20:09 -0800
X-Original-Message-ID <20170121192010.30681-2-f.fainelli@gmail.com>
X-Original-References <20170121192010.30681-1-f.fainelli@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1564221

Show key headers only | View raw


We have a device reference, utilize it instead of pr_warn().

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/hwmon/lm70.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
index d6ecd1a4be59..52c5cdd00448 100644
--- a/drivers/hwmon/lm70.c
+++ b/drivers/hwmon/lm70.c
@@ -72,7 +72,8 @@ static ssize_t temp1_input_show(struct device *dev,
 	 */
 	status = spi_write_then_read(spi, NULL, 0, &rxbuf[0], 2);
 	if (status < 0) {
-		pr_warn("spi_write_then_read failed with status %d\n", status);
+		dev_warn(dev, "spi_write_then_read failed with status %d\n",
+			 status);
 		goto out;
 	}
 	raw = (rxbuf[0] << 8) + rxbuf[1];
-- 
2.9.3

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn Florian Fainelli <f.fainelli@gmail.com> - 2017-01-21 20:30 +0100
  Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn Guenter Roeck <linux@roeck-us.net> - 2017-01-21 21:20 +0100
  Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn Joe Perches <joe@perches.com> - 2017-01-23 07:50 +0100
    Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn Joe Perches <joe@perches.com> - 2017-01-23 08:00 +0100
      Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn Julia Lawall <julia.lawall@lip6.fr> - 2017-01-23 13:10 +0100
    Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn Guenter Roeck <linux@roeck-us.net> - 2017-01-23 08:10 +0100
      Re: [PATCH 1/2] hwmon: (lm70) Utilize dev_warn instead of pr_warn Julia Lawall <julia.lawall@lip6.fr> - 2017-01-23 08:20 +0100

csiph-web