Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1564217

[PATCH 05/13] Input: misc - Use local variables consistently

Show all headers | View raw

If a function declares a variable to access a structure element,
use it conssistently.

The conversion was done automatically with coccinelle using
the following semantic patch.

// Catch function parameters.
// Handle those first to trigger reformatting.

@@
identifier d;
identifier fn;
identifier svar;
identifier elem;
type T;
identifier i;
expression e;
identifier fn;
expression list es;
@@

fn(...) {
  ...
  T d = &svar->elem;
<... when != d = e;
- fn(&svar->elem, es)
+ fn(d, es)
...> }

// Now address non-functions and multiple transformations in function
// parameters.

@@
identifier d;
identifier fn;
identifier svar;
identifier elem;
type T;
identifier i;
expression e;
@@

fn(...) {
  ...
  T d = &svar->elem;
<... when != d = e;
(
- &svar->elem
+ d
|
- svar->elem.i
+ d->i
)
...> }

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/input/misc/drv260x.c          | 2 +-
 drivers/input/misc/gpio_tilt_polled.c | 2 +-
 drivers/input/misc/hisi_powerkey.c    | 9 ++++-----
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
index 0a2b865b1000..fb089d36c0d6 100644
--- a/drivers/input/misc/drv260x.c
+++ b/drivers/input/misc/drv260x.c
@@ -538,7 +538,7 @@ static int drv260x_probe(struct i2c_client *client,
 
 	haptics->input_dev = devm_input_allocate_device(dev);
 	if (!haptics->input_dev) {
-		dev_err(&client->dev, "Failed to allocate input device\n");
+		dev_err(dev, "Failed to allocate input device\n");
 		return -ENOMEM;
 	}
 
diff --git a/drivers/input/misc/gpio_tilt_polled.c b/drivers/input/misc/gpio_tilt_polled.c
index f103b99d1852..6e217a45e39a 100644
--- a/drivers/input/misc/gpio_tilt_polled.c
+++ b/drivers/input/misc/gpio_tilt_polled.c
@@ -138,7 +138,7 @@ static int gpio_tilt_polled_probe(struct platform_device *pdev)
 
 	input->name = pdev->name;
 	input->phys = DRV_NAME"/input0";
-	input->dev.parent = &pdev->dev;
+	input->dev.parent = dev;
 
 	input->id.bustype = BUS_HOST;
 	input->id.vendor = 0x0001;
diff --git a/drivers/input/misc/hisi_powerkey.c b/drivers/input/misc/hisi_powerkey.c
index 675539c529ce..c4c42124a059 100644
--- a/drivers/input/misc/hisi_powerkey.c
+++ b/drivers/input/misc/hisi_powerkey.c
@@ -75,9 +75,9 @@ static int hi65xx_powerkey_probe(struct platform_device *pdev)
 	struct input_dev *input;
 	int irq, i, error;
 
-	input = devm_input_allocate_device(&pdev->dev);
+	input = devm_input_allocate_device(dev);
 	if (!input) {
-		dev_err(&pdev->dev, "failed to allocate input device\n");
+		dev_err(dev, "failed to allocate input device\n");
 		return -ENOMEM;
 	}
 
@@ -111,12 +111,11 @@ static int hi65xx_powerkey_probe(struct platform_device *pdev)
 
 	error = input_register_device(input);
 	if (error) {
-		dev_err(&pdev->dev, "failed to register input device: %d\n",
-			error);
+		dev_err(dev, "failed to register input device: %d\n", error);
 		return error;
 	}
 
-	device_init_wakeup(&pdev->dev, 1);
+	device_init_wakeup(dev, 1);
 
 	return 0;
 }
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/13] Input: Automated coccinelle cleanup (take 2) Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  [PATCH 11/13] Input: touchscreen - drop unnecessary calls to device_init_wakeup Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  [PATCH 10/13] Input: misc - drop unnecessary calls to device_init_wakeup Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  [PATCH 08/13] Input: touchscreen - Use local variables consistently Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  [PATCH 03/13] Input: touchscreen - Drop calls to platform_set_drvdata and i2c_set_clientdata Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  [PATCH 13/13] Input: misc - drop empty remove functions Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  [PATCH 02/13] Input: misc - Drop calls to platform_set_drvdata and i2c_set_clientdata Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  [PATCH 01/13] Input: keyboard - Drop calls to platform_set_drvdata and i2c_set_clientdata Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  [PATCH 09/13] Input: keyboard - drop unnecessary calls to device_init_wakeup Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  [PATCH 05/13] Input: misc - Use local variables consistently Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  [PATCH 04/13] Input: keyboard - Use local variables consistently Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
    Re: [PATCH 04/13] Input: keyboard - Use local variables consistently Linus Walleij <linus.walleij@linaro.org> - 2017-01-26 11:40 +0100
      Re: [PATCH 04/13] Input: keyboard - Use local variables consistently Guenter Roeck <linux@roeck-us.net> - 2017-01-26 15:30 +0100
      Re: [PATCH 04/13] Input: keyboard - Use local variables consistently Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-26 20:00 +0100
  [PATCH 12/13] Input: serio - drop unnecessary calls to device_init_wakeup Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  [PATCH 06/13] Input: mouse  Use local variables consistently Guenter Roeck <linux@roeck-us.net> - 2017-01-21 19:50 +0100
  Re: [PATCH 00/13] Input: Automated coccinelle cleanup (take 2) Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-22 09:40 +0100

csiph-web