Re: [PATCH v2 11/15] staging: iio: isl29028: remove unnecessary parenthesis

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 11/15] staging: iio: isl29028: remove unnecessary parenthesis
Date	2017-01-21 15:50 +0100
Message-ID	<t259n-59n-1@gated-at.bofh.it> (permalink)
References	<t0yfv-5dT-3@gated-at.bofh.it> <t0yfw-5dT-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 17/01/17 09:24, Brian Masney wrote:
> isl29028_write_raw() contains unnecessary parenthesis when checking to
> see if the passed in lux scale is valid. This patch removes the
> unnecessary parenthesis.
> 
> Signed-off-by: Brian Masney <masneyb@onstation.org>
hmm. Not sure I really care about this either way.

Ah well, applied.

Jonathan
> ---
>  drivers/staging/iio/light/isl29028.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/light/isl29028.c b/drivers/staging/iio/light/isl29028.c
> index e93077b..bc9c01d 100644
> --- a/drivers/staging/iio/light/isl29028.c
> +++ b/drivers/staging/iio/light/isl29028.c
> @@ -327,7 +327,7 @@ static int isl29028_write_raw(struct iio_dev *indio_dev,
>  			break;
>  		}
>  
> -		if ((val != 125) && (val != 2000)) {
> +		if (val != 125 && val != 2000) {
>  			dev_err(dev,
>  				"%s(): light: Lux scale %d is not in the set {125, 2000}\n",
>  				__func__, val);
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 11/15] staging: iio: isl29028: remove unnecessary parenthesis Brian Masney <masneyb@onstation.org> - 2017-01-17 10:30 +0100
  Re: [PATCH v2 11/15] staging: iio: isl29028: remove unnecessary  parenthesis Jonathan Cameron <jic23@kernel.org> - 2017-01-21 15:50 +0100

csiph-web