Re: [PATCH v1] PM / Domains: Keep the pd status during system PM phases

From	kbuild test robot <lkp@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v1] PM / Domains: Keep the pd status during system PM phases
Date	2017-01-20 03:20 +0100
Message-ID	<t1wY1-1cN-1@gated-at.bofh.it> (permalink)
References	<t1b7b-3XR-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Elaine,

[auto build test WARNING on pm/linux-next]
[also build test WARNING on v4.10-rc4 next-20170119]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Elaine-Zhang/PM-Domains-Keep-the-pd-status-during-system-PM-phases/20170120-091738
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-x016-201703 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from include/linux/delay.h:10,
                    from drivers/base/power/domain.c:9:
   drivers/base/power/domain.c: In function 'pm_genpd_suspend_noirq':
   drivers/base/power/domain.c:885:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
         dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
         ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/base/power/domain.c:884:2: note: in expansion of macro 'if'
     if (genpd->suspend_power_off ||
     ^~
   drivers/base/power/domain.c:885:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
         dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
         ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:149:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> drivers/base/power/domain.c:884:2: note: in expansion of macro 'if'
     if (genpd->suspend_power_off ||
     ^~
   drivers/base/power/domain.c:885:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
         dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
         ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:160:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> drivers/base/power/domain.c:884:2: note: in expansion of macro 'if'
     if (genpd->suspend_power_off ||
     ^~
   drivers/base/power/domain.c: In function 'pm_genpd_resume_noirq':
   drivers/base/power/domain.c:923:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
         dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
         ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
   drivers/base/power/domain.c:922:2: note: in expansion of macro 'if'
     if (genpd->suspend_power_off ||
     ^~
   drivers/base/power/domain.c:923:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
         dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
         ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:149:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
   drivers/base/power/domain.c:922:2: note: in expansion of macro 'if'
     if (genpd->suspend_power_off ||
     ^~
   drivers/base/power/domain.c:923:29: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
         dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
         ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/compiler.h:160:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
   drivers/base/power/domain.c:922:2: note: in expansion of macro 'if'
     if (genpd->suspend_power_off ||
     ^~

vim +/if +884 drivers/base/power/domain.c

   868	 * @dev: Device to suspend.
   869	 *
   870	 * Stop the device and remove power from the domain if all devices in it have
   871	 * been stopped.
   872	 */
   873	static int pm_genpd_suspend_noirq(struct device *dev)
   874	{
   875		struct generic_pm_domain *genpd;
   876		int ret;
   877	
   878		dev_dbg(dev, "%s()\n", __func__);
   879	
   880		genpd = dev_to_genpd(dev);
   881		if (IS_ERR(genpd))
   882			return -EINVAL;
   883	
 > 884		if (genpd->suspend_power_off ||
   885		    dev->power.wakeup_path && genpd_dev_active_wakeup(genpd, dev))
   886			return 0;
   887	
   888		if (genpd->dev_ops.stop && genpd->dev_ops.start) {
   889			ret = pm_runtime_force_suspend(dev);
   890			if (ret)
   891				return ret;
   892		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1] PM / Domains: Keep the pd status during system PM phases Elaine Zhang <zhangqing@rock-chips.com> - 2017-01-19 04:00 +0100
  Re: [PATCH v1] PM / Domains: Keep the pd status during system PM  phases kbuild test robot <lkp@intel.com> - 2017-01-20 03:20 +0100

csiph-web