Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562883

Re: [PATCH net-next] net/sched: cls_flower: reduce fl_change stack size

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 19 Jan 2017 10:45:31 +0100

> The new ARP support has pushed the stack size over the edge on ARM,
> as there are two large objects on the stack in this function (mask
> and tb) and both have now grown a bit more:
> 
> net/sched/cls_flower.c: In function 'fl_change':
> net/sched/cls_flower.c:928:1: error: the frame size of 1072 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> 
> We can solve this by dynamically allocating one or both of them.
> I first tried to do it just for the mask, but that only saved
> 152 bytes on ARM, while this version just does it for the 'tb'
> array, bringing the stack size back down to 664 bytes.
> 
> Fixes: 99d31326cbe6 ("net/sched: cls_flower: Support matching on ARP")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net/sched: cls_flower: reduce fl_change stack size Arnd Bergmann <arnd@arndb.de> - 2017-01-19 10:50 +0100
  Re: [PATCH net-next] net/sched: cls_flower: reduce fl_change stack  size Jiri Pirko <jiri@resnulli.us> - 2017-01-19 11:00 +0100
  Re: [PATCH net-next] net/sched: cls_flower: reduce fl_change stack  size David Miller <davem@davemloft.net> - 2017-01-19 17:40 +0100

csiph-web