Re: [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU
Date	2017-01-19 17:20 +0100
Message-ID	<t1nBo-3Mq-25@gated-at.bofh.it> (permalink)
References	<t0xW9-56o-3@gated-at.bofh.it> <t0xW9-56o-5@gated-at.bofh.it> <t0xW9-56o-1@gated-at.bofh.it> <t1nBo-3Mq-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jan 18, 2017 at 01:08:14AM +0800, Icenowy Zheng wrote:
> 
> 
> 17.01.2017, 17:05, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> > Hi,
> >
> > On Tue, Jan 17, 2017 at 02:01:14AM +0800, Icenowy Zheng wrote:
> >>  V3s has a similar but cut-down CCU to H3.
> >>
> >>  Add support for it.
> >>
> >>  Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> >>  ---
> >
> > Output from checkpatch:
> > total: 5 errors, 2 warnings, 3 checks, 857 lines checked
> 
> I remembered some errors' code is directly derived from ccu-sun8i-h3.c,
> so I generated a patch file for "clk: sunxi-ng: Add H3 clocks" and run
> checkpatch on it:
> total: 4 errors, 5 warnings, 1159 lines checked
> 
> Should I still get all errors fixed?

Yes, please.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-01-17 10:10 +0100
  Re: [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-01-19 17:20 +0100

csiph-web