Re: [PATCH v3 09/13] sata: ahci: export ahci_do_hardreset() locally

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 09/13] sata: ahci: export ahci_do_hardreset() locally
Date	2017-01-19 14:00 +0100
Message-ID	<t1ktQ-1Em-13@gated-at.bofh.it> (permalink)
References	<t0Ytk-4D1-5@gated-at.bofh.it> <t0Ytm-4D1-67@gated-at.bofh.it> <t13jk-7zO-5@gated-at.bofh.it> <t1iBI-uk-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 19, 2017 at 11:55:24AM +0100, Bartosz Golaszewski wrote:
> 2017-01-18 19:28 GMT+01:00 Tejun Heo <tj@kernel.org>:
> > Hello, Bartosz.
> >
> > On Wed, Jan 18, 2017 at 02:19:57PM +0100, Bartosz Golaszewski wrote:
> >> We need a way to retrieve the information about the online state of
> >> the link in the ahci-da850 driver.
> >>
> >> Create a new function: ahci_do_hardreset() which is called from
> >> ahci_hardreset() for backwards compatibility, but has an additional
> >> argument: 'online' - which can be used to check if the link is online
> >> after this function returns.
> >
> > Please just add @online to ahci_hardreset() and update the callers.
> > Other than that, the sata changes look good to me.
> >
> 
> Are you sure? There are 23 places in drivers/ata/ where the .hardreset
> callback is assigned. I'd prefer not to change the drivers I can't
> test. Besides all other **reset callbacks take three arguments -
> should we really only change one of them for a single driver's needs?

Ah, didn't realize this was the callback, sorry.  What you did is
perfect.  Please disregard my comment.

Thanks.

-- 
tejun

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 09/13] sata: ahci: export ahci_do_hardreset() locally Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-18 14:30 +0100
  Re: [PATCH v3 09/13] sata: ahci: export ahci_do_hardreset() locally Tejun Heo <tj@kernel.org> - 2017-01-18 19:40 +0100
    Re: [PATCH v3 09/13] sata: ahci: export ahci_do_hardreset() locally Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2017-01-19 12:00 +0100
      Re: [PATCH v3 09/13] sata: ahci: export ahci_do_hardreset() locally Tejun Heo <tj@kernel.org> - 2017-01-19 14:00 +0100

csiph-web