Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562600

Re: [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys core driver

Show all headers | View raw

Hi,

On Thu, Jan 19, 2017 at 12:15 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 01/17/2017 12:05 AM, Raviteja Garimella wrote:
>> This patch splits the amd5536udc driver into two -- one that does
>> pci device registration and the other file that does the rest of
>> the driver tasks like the gadget/ep ops etc for Synopsys UDC.
>>
>> This way of splitting helps in exporting core driver symbols which
>> can be used by any other platform/pci driver that is written for
>> the same Synopsys USB device controller.
>>
>> The current patch also includes a change in the Kconfig and Makefile.
>> A new config option USB_SNP_CORE will be selected automatically when
>> any one of the platform or pci driver for the same UDC is selected.
>>
>> Signed-off-by: Raviteja Garimella <raviteja.garimella@broadcom.com>
>
> Although the changes you have done make sense and it is most certainly a
> good idea to split udc core from bus specific glue logic, it is really
> hard to review the changes per-se because of the file rename, could that
> happen at a later time?

If you start looking at this specific patch from the header file (amd5536udc.h),
the additions in there comprise of:
- 9 function declarations
- some module parameter variable declarations that's moved out from the older
  common file amd5536udc.c
- 2 #includes that are needed by all files.

So, basically what's done for this split is that:
1. the static keyword is removed from those 9 functions in the new file
    snps_udc_core.c and are exported.
2. The module parameters declarations (since they are used in both core
    and pci file) are moved to the header file now.

Rest all is same as in old amd5536udc.c common file. It's just a copy from the
old file.

And, the file amd5536udc.c will now only do the pci device probe and
remove functions.

I hope this helps. Please let me know of any clarifications needed.
Since both the files are required to be reviewed, I think renaming is
inevitable.

Thanks,
Ravi

>
> Also, keep in mind that anytime a driver file is renamed, this poses a
> backport/maintenance issue where backporting fixes from latest upstream
> to a kernel version that has a different file/directory structure is a
> major pain.
> --
> Florian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC v2 0/5] Platform driver support for 'amd5536udc' driver  Raviteja Garimella <raviteja.garimella@broadcom.com> - 2017-01-17 09:10 +0100
  [RFC v2 3/5] UDC: Provide correct arguments for 'dma_pool_create' Raviteja Garimella <raviteja.garimella@broadcom.com> - 2017-01-17 09:10 +0100
  [RFC v2 2/5] UDC: make debug prints compatible with both pci and platform devices Raviteja Garimella <raviteja.garimella@broadcom.com> - 2017-01-17 09:10 +0100
  [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver Raviteja Garimella <raviteja.garimella@broadcom.com> - 2017-01-17 09:20 +0100
    Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform  driver Rob Herring <robh@kernel.org> - 2017-01-19 18:40 +0100
      Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform  driver Scott Branden <scott.branden@broadcom.com> - 2017-01-19 20:40 +0100
        Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform  driver Florian Fainelli <f.fainelli@gmail.com> - 2017-01-19 20:50 +0100
          Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform  driver Scott Branden <scott.branden@broadcom.com> - 2017-01-19 21:10 +0100
            Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform  driver Florian Fainelli <f.fainelli@gmail.com> - 2017-01-19 21:20 +0100
              Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform  driver Ray Jui <ray.jui@broadcom.com> - 2017-01-19 23:10 +0100
                Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform  driver Scott Branden <scott.branden@broadcom.com> - 2017-01-19 23:40 +0100
                Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform  driver Florian Fainelli <florian.fainelli@broadcom.com> - 2017-01-20 00:00 +0100
                Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver Rob Herring <robh@kernel.org> - 2017-01-20 15:00 +0100
      Re: [RFC v2 4/5] DT bindings documentation for Synopsys UDC platform driver Raviteja Garimella <raviteja.garimella@broadcom.com> - 2017-01-20 13:10 +0100
  [RFC v2 5/5] UDC: Add Synopsys UDC Platform driver Raviteja Garimella <raviteja.garimella@broadcom.com> - 2017-01-17 09:20 +0100
  Re: [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys  core driver Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 20:00 +0100
    Re: [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys  core driver Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-18 21:20 +0100
    Re: [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys  core driver Raviteja Garimella <raviteja.garimella@broadcom.com> - 2017-01-19 11:50 +0100
      Re: [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys  core driver Florian Fainelli <f.fainelli@gmail.com> - 2017-01-19 20:30 +0100
        Re: [RFC v2 1/5] UDC: Split the driver into amd (pci) and Synopsys  core driver Raviteja Garimella <raviteja.garimella@broadcom.com> - 2017-01-23 14:10 +0100

csiph-web