Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562562

Re: [PATCH perf/core 2/6] tools lib bpf: Fix grammar in map_idx warning

Show all headers | View raw

On 2017/1/19 7:57, Joe Stringer wrote:
> "Larger" is the comparative adjective form of "large".
>
> Signed-off-by: Joe Stringer <joe@ovn.org>
> ---
>   tools/lib/bpf/libbpf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index 350ee4c59f85..653b1b368deb 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -834,7 +834,7 @@ bpf_program__collect_reloc(struct bpf_program *prog,
>   
>   		map_idx = sym.st_value / prog->obj->map_len;
>   		if (map_idx >= nr_maps) {
> -			pr_warning("bpf relocation: map_idx %d large than %d\n",
> +			pr_warning("bpf relocation: map_idx %d larger than %d\n",

With my change to 1/6, this message become meaningless. We can
change it to:

     bpf relocation: failed to relocate instruction %u

Thank you.

>   				   (int)map_idx, (int)nr_maps - 1);
>   			return -LIBBPF_ERRNO__RELOC;
>   		}

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH perf/core 0/6] Libbpf improvements Joe Stringer <joe@ovn.org> - 2017-01-19 01:00 +0100
  [PATCH perf/core 2/6] tools lib bpf: Fix grammar in map_idx warning Joe Stringer <joe@ovn.org> - 2017-01-19 01:00 +0100
    Re: [PATCH perf/core 2/6] tools lib bpf: Fix grammar in map_idx  warning "Wangnan (F)" <wangnan0@huawei.com> - 2017-01-19 11:20 +0100
  [PATCH perf/core 4/6] tools lib bpf: Add set/is helpers for all prog types Joe Stringer <joe@ovn.org> - 2017-01-19 01:00 +0100
  [PATCH perf/core 5/6] tools lib bpf: Add libbpf_get_error() Joe Stringer <joe@ovn.org> - 2017-01-19 01:10 +0100
  [PATCH perf/core 1/6] tools lib bpf: Fix map offsets in relocation Joe Stringer <joe@ovn.org> - 2017-01-19 01:10 +0100
    Re: [PATCH perf/core 1/6] tools lib bpf: Fix map offsets in  relocation "Wangnan (F)" <wangnan0@huawei.com> - 2017-01-19 07:10 +0100
    [PATCH -improve] tools lib bpf: Fix map offsets in relocation Wang Nan <wangnan0@huawei.com> - 2017-01-19 11:00 +0100
  [PATCH perf/core 3/6] tools lib bpf: Define prog_type fns with macro Joe Stringer <joe@ovn.org> - 2017-01-19 01:10 +0100
  [PATCH perf/core 6/6] tools lib bpf: Add bpf_object__pin() Joe Stringer <joe@ovn.org> - 2017-01-19 01:10 +0100
    Re: [PATCH perf/core 6/6] tools lib bpf: Add bpf_object__pin() "Wangnan (F)" <wangnan0@huawei.com> - 2017-01-19 11:30 +0100
      Re: [PATCH perf/core 6/6] tools lib bpf: Add bpf_object__pin() Joe Stringer <joe@ovn.org> - 2017-01-20 01:00 +0100
  Re: [PATCH perf/core 0/6] Libbpf improvements "Wangnan (F)" <wangnan0@huawei.com> - 2017-01-19 11:30 +0100
    Re: [PATCH perf/core 0/6] Libbpf improvements Joe Stringer <joe@ovn.org> - 2017-01-23 02:20 +0100

csiph-web