Re: [PATCH 2/7] scsi: hisi_sas: modify some values of ITCT table

From	John Garry <john.garry@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/7] scsi: hisi_sas: modify some values of ITCT table
Date	2017-01-19 10:00 +0100
Message-ID	<t1gJA-7Hu-19@gated-at.bofh.it> (permalink)
References	<t10Ya-6eP-7@gated-at.bofh.it> <t10Ya-6eP-13@gated-at.bofh.it> <t1gzT-7DU-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 19/01/2017 08:44, Johannes Thumshirn wrote:
> On Thu, Jan 19, 2017 at 12:32:48AM +0800, John Garry wrote:
>> From: Xiang Chen <chenxiang66@hisilicon.com>
>>
>> Set SMP connection timeout and continue AWT timer;
>> Clear ITCT table when dev gone.
>>
>> Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
>> Signed-off-by: John Garry <john.garry@huawei.com>
>> ---
>>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 11 +++++++----
>>  1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
>> index 6c787eb..452e329 100644
>> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
>> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
>> @@ -334,6 +334,8 @@
>>  #define ITCT_HDR_MCR_MSK		(0xf << ITCT_HDR_MCR_OFF)
>>  #define ITCT_HDR_VLN_OFF		9
>>  #define ITCT_HDR_VLN_MSK		(0xf << ITCT_HDR_VLN_OFF)
>> +#define ITCT_HDR_SMP_TIMEOUT_OFF	16
>> +#define ITCT_HDR_AWT_CONTINUE_OFF	25
>>  #define ITCT_HDR_PORT_ID_OFF		28
>>  #define ITCT_HDR_PORT_ID_MSK		(0xf << ITCT_HDR_PORT_ID_OFF)
>>  /* qw2 */
>> @@ -696,6 +698,8 @@ static void setup_itct_v2_hw(struct hisi_hba *hisi_hba,
>>  	qw0 |= ((1 << ITCT_HDR_VALID_OFF) |
>>  		(device->linkrate << ITCT_HDR_MCR_OFF) |
>>  		(1 << ITCT_HDR_VLN_OFF) |
>> +		(0xfa << ITCT_HDR_SMP_TIMEOUT_OFF) |
>                  ^~ You may want to give that magic value a name.
>

Thanks for having a look.

We will create a new patch without the mysterious value.

Regards,
John

> Other than that,
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/7] scsi: hisi_sas: modify some values of ITCT table John Garry <john.garry@huawei.com> - 2017-01-18 17:10 +0100
  Re: [PATCH 2/7] scsi: hisi_sas: modify some values of ITCT table Johannes Thumshirn <jthumshirn@suse.de> - 2017-01-19 09:50 +0100
    Re: [PATCH 2/7] scsi: hisi_sas: modify some values of ITCT table John Garry <john.garry@huawei.com> - 2017-01-19 10:00 +0100

csiph-web