Re: [PATCH v3 5/6] ARM: dts: sunxi: add dtsi file for V3s SoC

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 5/6] ARM: dts: sunxi: add dtsi file for V3s SoC
Date	2017-01-20 22:20 +0100
Message-ID	<t1OLh-3Yv-29@gated-at.bofh.it> (permalink)
References	<t1NYS-3rw-17@gated-at.bofh.it> <t1OLh-3Yv-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Jan 20, 2017 at 01:54:47AM +0800, Icenowy Zheng wrote:
> As we have the pinctrl and clock support for the V3s SoC, it's now to
> run a mainline Linux on it.
> 
> So add a .dtsi file for it.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

Next time, please provide a description of what that SoC in your
commit log.

> +		rtc: rtc@01c20400 {
> +			compatible = "allwinner,sun6i-a31-rtc";
> +			reg = <0x01c20400 0x54>;
> +			interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
> +		};

Did you have the chance to actually test how the RTC was behaving?

Other RTC have been pretty bad at keeping time, this is probably
something you want to check.

Applied, 
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 5/6] ARM: dts: sunxi: add dtsi file for V3s SoC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-01-20 22:20 +0100

csiph-web