Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1563733

Re: [PATCH v5 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info

Show all headers | View raw

Hi Peter,


On Wednesday 18 January 2017 07:56 PM, Peter Zijlstra wrote:
> On Tue, Jan 17, 2017 at 07:47:22PM +0530, Hari Bathini wrote:
>> With the advert of container technologies like docker, that depend
>> on namespaces for isolation, there is a need for tracing support for
>> namespaces. This patch introduces new PERF_RECORD_NAMESPACES event
>> for tracing based on namespaces related info.
> This fails to mention the whole namespace of namespaces issue Eric

IIUC, Eric wanted to have device info saved for each namespace separately
to avoid the need for a namespace of namespaces in future.

> brought up. Where are we on that, and or why isn't it required?


I did address that in v4 and haven't changed it in v5.
I am not sure if it needs any mentioning in the changelog..

>> +/*
>> + * The maximum size of the name of each namespace
>> + */
>> +#define NS_NAME_SIZE				8
>> +
>> +struct perf_ns_link_info {
>> +	char	name[NS_NAME_SIZE];
> Do we really need a name? why?

Helps print new namespaces info along with name without any changes in
perf tool. Avoids hard-coding names too..

Thanks
Hari

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/3] perf: add support for analyzing events for containers Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-17 15:20 +0100
  [PATCH v5 3/3] perf tool: add cgroup identifier entry in perf report Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-17 15:20 +0100
  [PATCH v5 1/3] perf: add PERF_RECORD_NAMESPACES to include  namespaces related info Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-17 15:20 +0100
    Re: [PATCH v5 1/3] perf: add PERF_RECORD_NAMESPACES to include  namespaces related info Peter Zijlstra <peterz@infradead.org> - 2017-01-18 15:30 +0100
      Re: [PATCH v5 1/3] perf: add PERF_RECORD_NAMESPACES to include  namespaces related info Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-20 17:00 +0100
        Re: [PATCH v5 1/3] perf: add PERF_RECORD_NAMESPACES to include  namespaces related info Peter Zijlstra <peterz@infradead.org> - 2017-01-20 18:00 +0100
  [PATCH v5 2/3] perf tool: add PERF_RECORD_NAMESPACES to include  namespaces related info Hari Bathini <hbathini@linux.vnet.ibm.com> - 2017-01-17 15:20 +0100
    Re: [PATCH v5 2/3] perf tool: add PERF_RECORD_NAMESPACES to include  namespaces related info Jiri Olsa <jolsa@redhat.com> - 2017-01-18 14:30 +0100

csiph-web