Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1563699

Re: [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.

From Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups linux.kernel
Subject Re: [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices.
Date 2017-01-20 16:10 +0100
Message-ID <t1IZb-oG-9@gated-at.bofh.it> (permalink)
References <t1IFP-8tF-1@gated-at.bofh.it> <t1IFQ-8tF-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jan 20, 2017 at 08:12:11PM +0530, Chaitra P B wrote:
> Small glitch/degraded performance in Crusader is improved with SAS
> drives by removing unnecessary spinlocks while clearing scsi command
> in drivers internal lookup table.
> 
> Signed-off-by: Chaitra P B <chaitra.basappa@broadcom.com>
> Signed-off-by: Suganath Prabu S <suganath-prabu.subramani@broadcom.com>
> ---

Whats wrong with creating a __scsih_scsi_lookup_get_clear() and calling
it with the scsi_lookup_lock held from _scsih_scsi_lookup_get_clear()
instead of duplicating the code?

It's quite common in the linux kernel to have two functions func and __func,
where func is 

func()
{
	spin_lock();
	__func();
	spin_unlock();
}

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/4] mpt3sas driver Enhancements and Chaitra P B <chaitra.basappa@broadcom.com> - 2017-01-20 15:50 +0100
  [PATCH v2 3/4] mpt3sas: Fix Firmware fault state 0x2100 during heavy 4K RR FIO stress test. Chaitra P B <chaitra.basappa@broadcom.com> - 2017-01-20 15:50 +0100
    Re: [PATCH v2 3/4] mpt3sas: Fix Firmware fault state 0x2100 during  heavy 4K RR FIO stress test. Johannes Thumshirn <jthumshirn@suse.de> - 2017-01-20 16:50 +0100
      Re: [PATCH v2 3/4] mpt3sas: Fix Firmware fault state 0x2100 during  heavy 4K RR FIO stress test. Sreekanth Reddy <sreekanth.reddy@broadcom.com> - 2017-01-20 17:20 +0100
  [PATCH v2 4/4] mpt3sas: Updating driver version to v15.100.00.00 Chaitra P B <chaitra.basappa@broadcom.com> - 2017-01-20 15:50 +0100
    Re: [PATCH v2 4/4] mpt3sas: Updating driver version to v15.100.00.00 Johannes Thumshirn <jthumshirn@suse.de> - 2017-01-20 16:10 +0100
  [PATCH v2 1/4] mpt3sas: Added print to notify cable running at a degraded speed. Chaitra P B <chaitra.basappa@broadcom.com> - 2017-01-20 15:50 +0100
    Re: [PATCH v2 1/4] mpt3sas: Added print to notify cable running at a  degraded speed. Johannes Thumshirn <jthumshirn@suse.de> - 2017-01-20 16:10 +0100
    Re: [PATCH v2 1/4] mpt3sas: Added print to notify cable running at  a degraded speed. Joe Perches <joe@perches.com> - 2017-01-20 19:00 +0100
      Re: [PATCH v2 1/4] mpt3sas: Added print to notify cable running at  a degraded speed. Joe Perches <joe@perches.com> - 2017-01-20 19:20 +0100
  [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product targets with SAS devices. Chaitra P B <chaitra.basappa@broadcom.com> - 2017-01-20 15:50 +0100
    Re: [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product  targets with SAS devices. Johannes Thumshirn <jthumshirn@suse.de> - 2017-01-20 16:10 +0100
      Re: [PATCH v2 2/4] mpt3sas: Fix for Crusader to achieve product  targets with SAS devices. Sreekanth Reddy <sreekanth.reddy@broadcom.com> - 2017-01-20 17:30 +0100

csiph-web