Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1563562
| From | Marcelo Tosatti <mtosatti@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch 5/5] PTP: add kvm PTP driver |
| Date | 2017-01-20 14:20 +0100 |
| Message-ID | <t1HgL-7Iz-41@gated-at.bofh.it> (permalink) |
| References | <t1Gul-7bo-3@gated-at.bofh.it> <t1Gum-7bo-17@gated-at.bofh.it> <t1H74-7EL-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jan 20, 2017 at 01:58:33PM +0100, Paolo Bonzini wrote:
>
>
> On 20/01/2017 13:20, Marcelo Tosatti wrote:
> > + ret = kvm_hypercall2(KVM_HC_CLOCK_PAIRING,
> > + clock_off_gpa,
> > + KVM_CLOCK_PAIRING_WALLCLOCK);
> > + if (ret != 0) {
> > + pr_err("clock offset hypercall ret %lu\n", ret);
> > + spin_unlock(&kvm_ptp_lock);
> > + preempt_enable_notrace();
> > + return -EOPNOTSUPP;
> > + }
> > +
>
> Is it worth making this hypercall, or even all of ptp_kvm_get_time_fn, a
> pv_ops entry?
Well, i don't know how Xen is going to implement this. Maybe you can,
when you have more low level implementations to be able to generalize.
> But this looks good already, apart from my different preference on
> emulate_ptp_sys_offset_mean.
Sending v4 with the direct export of kvm clocksource.
Thanks!
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch 5/5] PTP: add kvm PTP driver Marcelo Tosatti <mtosatti@redhat.com> - 2017-01-20 13:30 +0100
Re: [patch 5/5] PTP: add kvm PTP driver Paolo Bonzini <pbonzini@redhat.com> - 2017-01-20 14:10 +0100
Re: [patch 5/5] PTP: add kvm PTP driver Marcelo Tosatti <mtosatti@redhat.com> - 2017-01-20 14:20 +0100
Re: [patch 5/5] PTP: add kvm PTP driver Radim Krcmar <rkrcmar@redhat.com> - 2017-01-20 15:20 +0100
Re: [patch 5/5] PTP: add kvm PTP driver Radim Krcmar <rkrcmar@redhat.com> - 2017-01-20 15:30 +0100
Re: [patch 5/5] PTP: add kvm PTP driver Marcelo Tosatti <mtosatti@redhat.com> - 2017-01-20 16:10 +0100
Re: [patch 5/5] PTP: add kvm PTP driver Paolo Bonzini <pbonzini@redhat.com> - 2017-01-20 18:20 +0100
Re: [patch 5/5] PTP: add kvm PTP driver Radim Krcmar <rkrcmar@redhat.com> - 2017-01-20 19:10 +0100
Re: [patch 5/5] PTP: add kvm PTP driver Marcelo Tosatti <mtosatti@redhat.com> - 2017-01-20 20:40 +0100
Re: [patch 5/5] PTP: add kvm PTP driver Paolo Bonzini <pbonzini@redhat.com> - 2017-01-21 09:10 +0100
csiph-web