Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1563586

Re: [PATCH v10 3/4] console: Add persistent scrollback buffers for all VGA consoles

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v10 3/4] console: Add persistent scrollback buffers for all VGA consoles
Date 2017-01-20 14:40 +0100
Message-ID <t1HA6-7Ps-33@gated-at.bofh.it> (permalink)
References (2 earlier) <t1kWS-23z-29@gated-at.bofh.it> <t1nBo-3Mq-31@gated-at.bofh.it> <t1o4r-3Xc-55@gated-at.bofh.it> <t1u0a-7Tg-23@gated-at.bofh.it> <t1HgK-7Iz-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jan 20, 2017 at 02:16:11PM +0100, Adam Borowski wrote:
> On Fri, Jan 20, 2017 at 12:04:12AM +0100, Adam Borowski wrote:
> > On Thu, Jan 19, 2017 at 05:33:14PM +0100, Greg KH wrote:
> > > On Thu, Jan 19, 2017 at 05:12:15PM +0100, Manuel Schölling wrote:
> > > > On Thu, 2017-01-19 at 14:23 +0100, Greg KH wrote:
> > > > > On Fri, Jan 13, 2017 at 09:07:57PM +0100, Manuel Schölling wrote:
> > > > > > +	  This feature might break your tool of choice to flush
> > > > > > the scrollback
> > > > > > +	  buffer, e.g. clear(1) will work fine but Debian's
> > > > > > clear_console(1)
> > > > > > +	  will be broken, which might cause security issues.
> > > > > > +	  You can use the escape sequence \e[3J instead if this
> > > > > > feature is
> > > > > > +	  activated.
> > > 
> > > I'd recommend that patch get to clear_console() first, having it use the
> > > new escape sequence, if it isn't supported, shouldn't cause any
> > > problems, right?
> > 
> > doko: would you consider, pretty please with a cherry on top, applying the
> > patch I've sent to this bug?  The privacy/security issue is pretty minor and
> > applies only to a tiny fraction of users, but I understand why Greg is
> > reluctant.
> 
> # Subject: Bug#845177 closed by Matthias Klose <doko@debian.org>
> #
> # This is an automatic notification regarding your Bug report
> # which was filed against the bash package:
> #
> # #845177: clear_console: assumes VT switch clears scrollback
> #
> # It has been closed by Matthias Klose <doko@debian.org>.
> [...]
> # Changes:
> #    * clear_console: Securely erase the current console. Closes: #845177.

This means it was accepted?  Or rejected?

confused,

greg k-h

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v10 3/4] console: Add persistent scrollback buffers for  all VGA consoles Greg KH <gregkh@linuxfoundation.org> - 2017-01-19 14:30 +0100
  Re: [PATCH v10 3/4] console: Add persistent scrollback buffers for  all VGA consoles Manuel Schölling <manuel.schoelling@gmx.de> - 2017-01-19 17:20 +0100
    Re: [PATCH v10 3/4] console: Add persistent scrollback buffers for  all VGA consoles Greg KH <gregkh@linuxfoundation.org> - 2017-01-19 17:50 +0100
      Bug#845177: [PATCH v10 3/4] console: Add persistent scrollback buffers for all VGA consoles Adam Borowski <kilobyte@angband.pl> - 2017-01-20 00:10 +0100
        Re: [PATCH v10 3/4] console: Add persistent scrollback buffers for  all VGA consoles Adam Borowski <kilobyte@angband.pl> - 2017-01-20 14:20 +0100
          Re: [PATCH v10 3/4] console: Add persistent scrollback buffers for  all VGA consoles Greg KH <gregkh@linuxfoundation.org> - 2017-01-20 14:40 +0100
            Re: [PATCH v10 3/4] console: Add persistent scrollback buffers for  all VGA consoles Adam Borowski <kilobyte@angband.pl> - 2017-01-20 15:30 +0100
    Re: [PATCH v10 3/4] console: Add persistent scrollback buffers for  all VGA consoles Adam Borowski <kilobyte@angband.pl> - 2017-01-19 20:20 +0100

csiph-web