Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1563550

[PATCH] net: sctp: fix array overrun read on sctp_timer_tbl

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The comparison on the timeout can lead to an array overrun
read on sctp_timer_tbl because of an off-by-one error. Fix
this by using < instead of <= and also compare to the array
size rather than SCTP_EVENT_TIMEOUT_MAX.

Fixes CoverityScan CID#1397639 ("Out-of-bounds read")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/sctp/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/sctp/debug.c b/net/sctp/debug.c
index 95d7b15..e371a0d 100644
--- a/net/sctp/debug.c
+++ b/net/sctp/debug.c
@@ -166,7 +166,7 @@ static const char *const sctp_timer_tbl[] = {
 /* Lookup timer debug name. */
 const char *sctp_tname(const sctp_subtype_t id)
 {
-	if (id.timeout <= SCTP_EVENT_TIMEOUT_MAX)
+	if (id.timeout < ARRAY_SIZE(sctp_timer_tbl))
 		return sctp_timer_tbl[id.timeout];
 	return "unknown_timer";
 }
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: sctp: fix array overrun read on sctp_timer_tbl Colin King <colin.king@canonical.com> - 2017-01-20 14:10 +0100
  Re: [PATCH] net: sctp: fix array overrun read on sctp_timer_tbl Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2017-01-20 14:20 +0100
    Re: [PATCH] net: sctp: fix array overrun read on sctp_timer_tbl Colin Ian King <colin.king@canonical.com> - 2017-01-20 14:20 +0100
      Re: [PATCH] net: sctp: fix array overrun read on sctp_timer_tbl Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> - 2017-01-20 14:30 +0100
  Re: [PATCH] net: sctp: fix array overrun read on sctp_timer_tbl David Miller <davem@davemloft.net> - 2017-01-20 17:30 +0100

csiph-web