Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1563492

Re: Re: [PATCH] rtlwifi: rtl8192x: Enabling and disabling hardware interrupts after enabling local irq flags

From "Lino Sanfilippo" <LinoSanfilippo@gmx.de>
Newsgroups linux.kernel
Subject Re: Re: [PATCH] rtlwifi: rtl8192x: Enabling and disabling hardware interrupts after enabling local irq flags
Date 2017-01-20 12:30 +0100
Message-ID <t1Fyh-6Cb-9@gated-at.bofh.it> (permalink)
References <t1Fyh-6Cb-11@gated-at.bofh.it> <t1xr4-1mW-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi,

>
> 
> This patch should be enhanced with the smb_xx() calls as suggested by by Lino.
> 

If you do this, please place the smp_rmb() before the if condition in the irq
handler like

smp_rmb();
if (rtlpci->irq_enabled == 0) {
    return ret;


as I think that the suggestion I made before was not correct (sorry for the
confusion). 

Regards,
Lino

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] rtlwifi: rtl8192x: Enabling and disabling hardware  interrupts after enabling local irq flags Larry Finger <Larry.Finger@lwfinger.net> - 2017-01-20 03:50 +0100
  Re: Re: [PATCH] rtlwifi: rtl8192x: Enabling and disabling hardware  interrupts after enabling local irq flags "Lino Sanfilippo" <LinoSanfilippo@gmx.de> - 2017-01-20 12:30 +0100
  Re: [PATCH] rtlwifi: rtl8192x: Enabling and disabling hardware  interrupts after enabling local irq flags Larry Finger <Larry.Finger@lwfinger.net> - 2017-01-20 17:40 +0100

csiph-web