Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization
Date	2017-01-20 11:10 +0100
Message-ID	<t1EiS-5VC-11@gated-at.bofh.it> (permalink)
References	(6 earlier) <t1kat-1xr-7@gated-at.bofh.it> <t1mlY-2PW-15@gated-at.bofh.it> <t1nBo-3Mq-43@gated-at.bofh.it> <t1oe6-40V-49@gated-at.bofh.it> <t1B1D-3Nl-9@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Fri, 2017-01-20 at 07:39 +0100, Thierry Reding wrote:
> On Thu, Jan 19, 2017 at 05:52:10PM +0100, Clemens Gruber wrote:
> > On Thu, Jan 19, 2017 at 06:10:08PM +0200, Andy Shevchenko wrote:
> > > Combining with your proposal I would see the best approach is to
> > > set
> > > pca->period_ns accordingly to current prescaler value if you want
> > > to.

> > I'll send v2 of patch 2/2 with aforementioned changes in the next
> > days.
> 
> Like I said above, I think atomic API conversion wouldn't be very
> difficult for this driver and it has the added advantage of giving you
> the proper infrastructure to do this rather than having to duplicate
> it in the driver.
> 
> That would be my preference, but I'm willing to take v2 of 2/2 as well
> if it ends up being really nice and compact. =)

I think we may split to this fix and separate change to move to atomic
API. Does it sound reasonable?

P.S. <offtopic>Can you comment further pwm-lpss changes Mika and I
did?</offtopic>

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Thread

Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Thierry Reding <thierry.reding@gmail.com> - 2017-01-18 12:10 +0100
  Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-18 12:20 +0100
    Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Clemens Gruber <clemens.gruber@pqgruber.com> - 2017-01-18 15:00 +0100
      Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-18 15:10 +0100
        Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Clemens Gruber <clemens.gruber@pqgruber.com> - 2017-01-18 15:30 +0100
          Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-19 13:40 +0100
            Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Clemens Gruber <clemens.gruber@pqgruber.com> - 2017-01-19 16:00 +0100
              Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-19 17:20 +0100
                Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Clemens Gruber <clemens.gruber@pqgruber.com> - 2017-01-19 18:00 +0100
                Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-19 18:10 +0100
                Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Thierry Reding <thierry.reding@gmail.com> - 2017-01-20 07:40 +0100
                Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-20 11:10 +0100
                Re: [PATCH 2/2] pwm: pca9685: fix prescaler initialization Clemens Gruber <clemens.gruber@pqgruber.com> - 2017-01-25 19:10 +0100

csiph-web