Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1563424

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

Show all headers | View raw

On Thu, Jan 19, 2017 at 12:55:27PM -0500, Cathy Avery wrote:
> 
> 
> On 01/18/2017 06:15 PM, Dan Carpenter wrote:
> >On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote:
> >>Enable FC lightweight host option so that the luns exposed by
> >>the driver may be manually scanned.
> >>
> >>Signed-off-by: Cathy Avery <cavery@redhat.com>
> >>---
> >>  drivers/scsi/storvsc_drv.c | 6 +-----
> >>  1 file changed, 1 insertion(+), 5 deletions(-)
> >>
> >>diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> >>index 888e16e..fc1d6ba 100644
> >>--- a/drivers/scsi/storvsc_drv.c
> >>+++ b/drivers/scsi/storvsc_drv.c
> >>@@ -1882,6 +1882,7 @@ static struct hv_driver storvsc_drv = {
> >>  static struct fc_function_template fc_transport_functions = {
> >>  	.show_host_node_name = 1,
> >>  	.show_host_port_name = 1,
> >>+	.lightweight_transport = 1,
> >>  };
> >>  #endif
> >>@@ -1906,11 +1907,6 @@ static int __init storvsc_drv_init(void)
> >>  	fc_transport_template = fc_attach_transport(&fc_transport_functions);
> >>  	if (!fc_transport_template)
> >>  		return -ENODEV;
> >>-
> >>-	/*
> >>-	 * Install Hyper-V specific timeout handler.
> >>-	 */
> >>-	fc_transport_template->eh_timed_out = storvsc_eh_timed_out;
> >I don't undestand how removing this is related.
> 
> Its not related but it is also not necessary so I took it out. The
> default scsi timeout handler will be used.
> 
> I can certainly put it back.

I'm not sure that we understand each other properly.

Has this patch already been committed?  If so, then there is no need to
put it back.

But it if hasn't been committed, can you resend the patches with that
bit broken out into a separate patch with its own changelog?  Patches
should only do one thing but you're  saying that it's doing two
unrelated things.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Cathy Avery <cavery@redhat.com> - 2017-01-18 21:40 +0100
  Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-19 00:20 +0100
    Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Cathy Avery <cavery@redhat.com> - 2017-01-19 19:30 +0100
      Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-20 10:40 +0100
        Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Cathy Avery <cavery@redhat.com> - 2017-01-22 20:00 +0100
          Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-22 20:30 +0100
  Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Fam Zheng <famz@redhat.com> - 2017-01-23 04:20 +0100
    Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Cathy Avery <cavery@redhat.com> - 2017-01-23 22:10 +0100

csiph-web