Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1563366

[PATCH RESEND 3/3] serial: 8250_omap: Remove rx_dma_broken flag

From Vignesh R <vigneshr@ti.com>
Newsgroups linux.kernel
Subject [PATCH RESEND 3/3] serial: 8250_omap: Remove rx_dma_broken flag
Date 2017-01-20 09:30 +0100
Message-ID <t1CK6-4SH-9@gated-at.bofh.it> (permalink)
References <t1CAp-4Pq-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


8250 UART DMA support was marked broken by default as it was not
possible to pause ongoing RX DMA transfer. Now that both SDMA and
EDMA can support pause operation for RX DMA transactions, don't set
rx_dma_broken to true by default. With this patch 8250_omap driver will
use DMA by default.

Signed-off-by: Vignesh R <vigneshr@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
---
 drivers/tty/serial/8250/8250_omap.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
index 97766dcd67d4..68a6393d9636 100644
--- a/drivers/tty/serial/8250/8250_omap.c
+++ b/drivers/tty/serial/8250/8250_omap.c
@@ -1221,11 +1221,6 @@ static int omap8250_probe(struct platform_device *pdev)
 			priv->omap8250_dma.rx_size = RX_TRIGGER;
 			priv->omap8250_dma.rxconf.src_maxburst = RX_TRIGGER;
 			priv->omap8250_dma.txconf.dst_maxburst = TX_TRIGGER;
-			/*
-			 * pause is currently not supported atleast on omap-sdma
-			 * and edma on most earlier kernels.
-			 */
-			priv->rx_dma_broken = true;
 		}
 	}
 #endif
-- 
2.11.0

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH RESEND 0/3] serial: 8250_omap: Enable DMA support Vignesh R <vigneshr@ti.com> - 2017-01-20 09:20 +0100
  [PATCH RESEND 1/3] serial: 8250_omap: pause DMA only if DMA transfer in progress Vignesh R <vigneshr@ti.com> - 2017-01-20 09:20 +0100
  [PATCH RESEND 3/3] serial: 8250_omap: Remove rx_dma_broken flag Vignesh R <vigneshr@ti.com> - 2017-01-20 09:30 +0100

csiph-web