Re: [RFC] HWPOISON: soft offlining for non-lru movable page

From	Yisheng Xie <xieyisheng1@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [RFC] HWPOISON: soft offlining for non-lru movable page
Date	2017-01-19 02:30 +0100
Message-ID	<t19I5-3fA-5@gated-at.bofh.it> (permalink)
References	<t0PJn-7Ew-1@gated-at.bofh.it> <t0VlM-2Ex-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2017/1/18 17:51, Michal Hocko wrote:
> On Wed 18-01-17 12:00:54, Yisheng Xie wrote:
>> This patch is to extends soft offlining framework to support
>> non-lru page, which already support migration after
>> commit bda807d44454 ("mm: migrate: support non-lru movable page
>> migration")
>>
>> When memory corrected errors occur on a non-lru movable page,
>> we can choose to stop using it by migrating data onto another
>> page and disable the original (maybe half-broken) one.
> 
> soft_offline_movable_page duplicates quite a lot from
> __soft_offline_page. Would it be better to handle both cases in
> __soft_offline_page?
> 
Hi Michal,
Thanks for reviewing.
Yes, the most code of soft_offline_movable_page is duplicates with
__soft_offline_page, I use a single function to make code looks clear,
just as what soft_offline_hugetlb_page do.

I will try to make a v2 as your suggestion.

Thanks
Yisheng Xie.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC] HWPOISON: soft offlining for non-lru movable page Yisheng Xie <xieyisheng1@huawei.com> - 2017-01-18 05:10 +0100
  Re: [RFC] HWPOISON: soft offlining for non-lru movable page Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2017-01-18 11:00 +0100
    Re: [RFC] HWPOISON: soft offlining for non-lru movable page Yisheng Xie <xieyisheng1@huawei.com> - 2017-01-20 11:00 +0100
      Re: [RFC] HWPOISON: soft offlining for non-lru movable page Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> - 2017-01-23 05:50 +0100
  Re: [RFC] HWPOISON: soft offlining for non-lru movable page Michal Hocko <mhocko@kernel.org> - 2017-01-18 11:10 +0100
    Re: [RFC] HWPOISON: soft offlining for non-lru movable page Yisheng Xie <xieyisheng1@huawei.com> - 2017-01-19 02:30 +0100

csiph-web