Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1562330
| From | Andi Kleen <ak@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 04/11] perf, tools: Support per pmu json aliases |
| Date | 2017-01-19 01:30 +0100 |
| Message-ID | <t18M2-2Gh-11@gated-at.bofh.it> (permalink) |
| References | <sVySR-85Q-27@gated-at.bofh.it> <sVz2y-8cw-41@gated-at.bofh.it> <t0XnA-3ZK-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> > index 8bffe99d8e3f..4bfc98953aba 100644 > > --- a/tools/perf/util/pmu.c > > +++ b/tools/perf/util/pmu.c > > @@ -587,14 +587,13 @@ static struct perf_pmu *pmu_lookup(const char *name) > > if (pmu_format(name, &format)) > > return NULL; > > > > - if (pmu_aliases(name, &aliases)) > > + if (pmu_type(name, &type)) > > return NULL; > > > > - pmu_add_cpu_aliases(&aliases, name); > > - > > - if (pmu_type(name, &type)) > > + if (pmu_aliases(name, &aliases)) > > return NULL; > > > > + pmu_add_cpu_aliases(&aliases, name); > > AFAICS you switched the calls.. how does it matter? It avoids lots of duplicate messages with -v (and also is more efficient) -Andi
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 04/11] perf, tools: Support per pmu json aliases Jiri Olsa <jolsa@redhat.com> - 2017-01-18 13:20 +0100
Re: [PATCH 04/11] perf, tools: Support per pmu json aliases Andi Kleen <ak@linux.intel.com> - 2017-01-19 01:30 +0100
Re: [PATCH 04/11] perf, tools: Support per pmu json aliases Jiri Olsa <jolsa@redhat.com> - 2017-01-19 11:50 +0100
csiph-web