Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1562155

Re: [PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0]

From Florian Fainelli <f.fainelli@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0]
Date 2017-01-18 21:40 +0100
Message-ID <t15bs-o6-45@gated-at.bofh.it> (permalink)
References <t0NxT-67U-3@gated-at.bofh.it> <t0NxT-67U-1@gated-at.bofh.it> <t0Y0h-4cB-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 01/18/2017 04:50 AM, Andrew Lunn wrote:
> On Tue, Jan 17, 2017 at 08:41:39PM -0500, Vivien Didelot wrote:
>> Now that the DSA Ethernet switches are true Linux devices, the CPU
>> switch is not necessarily the first one. If its address is higher than
>> the second switch on the same MDIO bus, its index will be 1, not 0.
>>
>> Avoid any confusion by using dst->cpu_switch instead of dst->ds[0].
>>
>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0] Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-18 02:50 +0100
  Re: [PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0] Andrew Lunn <andrew@lunn.ch> - 2017-01-18 14:00 +0100
    Re: [PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0] Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 21:40 +0100
  Re: [PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0] Florian Fainelli <f.fainelli@gmail.com> - 2017-01-18 21:40 +0100
  Re: [PATCH net-next 2/2] net: dsa: use cpu_switch instead of ds[0] David Miller <davem@davemloft.net> - 2017-01-18 23:10 +0100

csiph-web