Re: [PATCHv2 4/7] TAP: Abstract type of virtual interface from tap implementation

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2 4/7] TAP: Abstract type of virtual interface from tap implementation
Date	2017-01-18 22:30 +0100
Message-ID	<t15XR-Vm-35@gated-at.bofh.it> (permalink)
References	<t0LZ7-5nf-3@gated-at.bofh.it> <t0LZ7-5nf-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Sainath Grandhi <sainath.grandhi@intel.com>
Date: Tue, 17 Jan 2017 16:03:03 -0800

> @@ -46,22 +51,52 @@ static struct cdev macvtap_cdev;
>  #define TUN_OFFLOADS (NETIF_F_HW_CSUM | NETIF_F_TSO_ECN | NETIF_F_TSO | \
>  		      NETIF_F_TSO6 | NETIF_F_UFO)
>  
> +static void macvtap_count_tx_dropped(struct tap_dev *tap)
> +{
> +	struct macvlan_dev *vlan = (struct macvlan_dev *)container_of(tap, struct macvtap_dev, tap);
 ...
> +static void macvtap_count_rx_dropped(struct tap_dev *tap)
> +{
> +	struct macvlan_dev *vlan = (struct macvlan_dev *)container_of(tap, struct macvtap_dev, tap);
 ...
> +static void macvtap_update_features(struct tap_dev *tap,
> +				    netdev_features_t features)
> +{
> +	struct macvlan_dev *vlan = (struct macvlan_dev *)container_of(tap, struct macvtap_dev, tap);

These casts should be completely unnecessary, please remove them.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2 4/7] TAP: Abstract type of virtual interface from tap  implementation Sainath Grandhi <sainath.grandhi@intel.com> - 2017-01-18 01:10 +0100
  Re: [PATCHv2 4/7] TAP: Abstract type of virtual interface from tap  implementation David Miller <davem@davemloft.net> - 2017-01-18 22:30 +0100

csiph-web