Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1562175

__mutex_lock_common() unlikely very likely

Show all headers | View raw

Chris,

My branch tracer flagged the unlikely in __mutex_lock_common() as
always hit. That's the:

	if (use_ww_ctx) {
		[...]
		if (unlikely(ww_ctx == READ_ONCE(ww->ctx)))
			return -EALREADY;
	}

This is hit 100% of the time, and its coming from the drm logic:

for example:

<stack trace>
 => drm_atomic_get_crtc_state
 => drm_atomic_helper_duplicate_state
 => intel_modeset_init
 => i915_driver_load
 => i915_pci_probe
 => local_pci_probe
 => pci_device_probe
 => driver_probe_device
 => __driver_attach
 => bus_for_each_dev
 => driver_attach
 => bus_add_driver
 => driver_register
 => __pci_register_driver
 => ext4_has_free_clusters
 => do_one_initcall
 => do_init_module
 => load_module
 => SYSC_init_module
 => SyS_init_module
 => entry_SYSCALL_64_fastpath

This is happening on 3 boxes of mine running normal loads (servers,
email, facebook, etc).

Commit 0422e83d84ae2 says:

    Recursive locking for ww_mutexes was originally conceived as an
    exception. However, it is heavily used by the DRM atomic modesetting
    code. Currently, the recursive deadlock is checked after we have queued
    up for a busy-spin and as we never release the lock, we spin until
    kicked, whereupon the deadlock is discovered and reported.

Should this be converted to a likely?

-- Steve

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

__mutex_lock_common() unlikely very likely Steven Rostedt <rostedt@goodmis.org> - 2017-01-18 22:10 +0100
  Re: __mutex_lock_common() unlikely very likely Chris Wilson <chris@chris-wilson.co.uk> - 2017-01-19 10:00 +0100
    Re: __mutex_lock_common() unlikely very likely Steven Rostedt <rostedt@goodmis.org> - 2017-01-19 14:40 +0100
    [PATCH] mutex: Remove ww_ctx unlikely() from __mutex_lock_common() "Steven Rostedt (VMware)" <rostedt@goodmis.org> - 2017-01-19 15:10 +0100
      Re: [PATCH] mutex: Remove ww_ctx unlikely() from  __mutex_lock_common() Steven Rostedt <rostedt@goodmis.org> - 2017-01-19 18:00 +0100
      Re: [PATCH] mutex: Remove ww_ctx unlikely() from  __mutex_lock_common() Peter Zijlstra <peterz@infradead.org> - 2017-01-19 22:00 +0100

csiph-web