Groups > linux.kernel > #1562079

Re: [PATCH v2 4/6] platform/x86: dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/6] platform/x86: dell-laptop: import dell_micmute_led_set() from drivers/leds/dell-led.c
Date	2017-01-18 20:20 +0100
Message-ID	<t13W1-83l-7@gated-at.bofh.it> (permalink)
References	<t0fwd-WM-3@gated-at.bofh.it> <t0fwe-WM-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 16, 2017 at 3:22 PM, Michał Kępień <kernel@kempniu.pl> wrote:
> To ensure all users of dell-smbios are in drivers/platform/x86, move the
> dell_micmute_led_set() method from drivers/leds/dell-led.c to
> drivers/platform/x86/dell-laptop.c.
>

Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Couple of nitpicks below.

> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -30,6 +30,7 @@
>  #include <linux/i8042.h>
>  #include <linux/debugfs.h>

>  #include <linux/seq_file.h>
> +#include <linux/dell-led.h>

Perhaps move this one line above

> +#define GLOBAL_MIC_MUTE_ENABLE 0x364
> +#define GLOBAL_MIC_MUTE_DISABLE 0x365

Same as Pali told.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/6] platform/x86: dell-laptop: import  dell_micmute_led_set() from drivers/leds/dell-led.c Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-18 20:20 +0100

csiph-web