Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1561891

Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC

Show all headers | View raw

Hello Marc,

On 01/18/2017 07:53 AM, Marc Zyngier wrote:
> Since everybody copied my own mistake from the DT binding example,
> let's address all the offenders in one swift go.
> 
> Most of them got the CPU interface size wrong (4kB, while it should
> be 8kB), except for both keystone platforms which got the control
> interface wrong (4kB instead of 8kB).
> 
> In the couple of cases were I knew for sure what implementation
> was used, I've added the "arm,gic-400" compatible string. I'm 99%
> sure that this is what everyong is using, but short of having the
> TRM for all the other SoCs, I've let them alone.
> 
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  arch/arm/boot/dts/exynos3250.dtsi    | 2 +-
>  arch/arm/boot/dts/exynos5.dtsi       | 2 +-
>  arch/arm/boot/dts/exynos5260.dtsi    | 2 +-
>  arch/arm/boot/dts/exynos5440.dtsi    | 2 +-

I've looked at the Exynos5250 and Exynos5420 TRM and both say that adopts
GIC-400, so I think it's safe for you to also update the compatible in the
exynos5.dtsi. Unfortunately I don't have manuals for 3250, 5260 and 5440.

The register map changes looks good to me, so for Exynos:

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Marc Zyngier <marc.zyngier@arm.com> - 2017-01-18 12:00 +0100
  Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Matthias Brugger <matthias.bgg@gmail.com> - 2017-01-18 12:40 +0100
  Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Robin Murphy <robin.murphy@arm.com> - 2017-01-18 13:00 +0100
    Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Marc Zyngier <marc.zyngier@arm.com> - 2017-01-18 14:30 +0100
  Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Heiko Stübner <heiko@sntech.de> - 2017-01-18 13:00 +0100
  Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-01-18 14:00 +0100
  Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-01-18 14:40 +0100
  Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-18 15:20 +0100
  Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Javier Martinez Canillas <javier@osg.samsung.com> - 2017-01-18 16:20 +0100
    Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Marc Zyngier <marc.zyngier@arm.com> - 2017-01-18 16:30 +0100
  Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-01-18 17:50 +0100
  Re: [PATCH 2/2] ARM: DTS: Fix register map for virt-capable GIC Shawn Guo <shawnguo@kernel.org> - 2017-01-23 11:00 +0100

csiph-web