Groups > linux.kernel > #1561908

Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias string

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Andi Kleen <ak@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias string
Date	Wed, 18 Jan 2017 16:50:02 +0100
Message-ID	<t10EO-5Sv-5@gated-at.bofh.it> (permalink)
References	<sVySR-85Q-27@gated-at.bofh.it> <sVz2x-8cw-7@gated-at.bofh.it> <t0Xxg-430-9@gated-at.bofh.it>
X-Original-To	Jiri Olsa <jolsa@redhat.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.33,249,1477983600"; d="scan'208";a="1095752139"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.7.1 (2016-10-04)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	20
Organization	linux.* mail to news gateway
X-Original-Cc	Andi Kleen <andi@firstfloor.org>, acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org
X-Original-Date	Wed, 18 Jan 2017 07:45:09 -0800
X-Original-Message-ID	<20170118154509.GD5460@tassilo.jf.intel.com>
X-Original-References	<20170103150833.6694-1-andi@firstfloor.org> <20170103150833.6694-7-andi@firstfloor.org> <20170118121606.GC11946@krava>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1561908

Show key headers only | View raw

On Wed, Jan 18, 2017 at 01:16:06PM +0100, Jiri Olsa wrote:
> On Tue, Jan 03, 2017 at 07:08:28AM -0800, Andi Kleen wrote:
> 
> SNIP
> 
> > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> > index 4bfc98953aba..e0c43698fd62 100644
> > --- a/tools/perf/util/pmu.c
> > +++ b/tools/perf/util/pmu.c
> > @@ -275,6 +275,8 @@ static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name,
> >  		snprintf(alias->unit, sizeof(alias->unit), "%s", unit);
> >  	}
> >  	alias->per_pkg = perpkg && sscanf(perpkg, "%d", &num) == 1 && num == 1;
> > +	alias->str = strdup(val);
> 
> where's this one released?

Aliases are never released AFAIK?

-Andi

Thread

Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias  string Jiri Olsa <jolsa@redhat.com> - 2017-01-18 13:30 +0100
  Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias  string Andi Kleen <ak@linux.intel.com> - 2017-01-18 16:50 +0100
    Re: [PATCH 06/11] perf, tools: Add debug support for outputing alias  string Jiri Olsa <jolsa@redhat.com> - 2017-01-18 17:30 +0100

csiph-web