Re: [PATCH] x86/mce: Fix initialization error warning

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/mce: Fix initialization error warning
Date	2017-01-17 10:20 +0100
Message-ID	<t0y5P-59Z-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <t0nDs-6Nj-7@gated-at.bofh.it> <t0oga-725-7@gated-at.bofh.it> <t0oJb-7x8-1@gated-at.bofh.it> <t0p2y-7EL-19@gated-at.bofh.it> <t0xt7-4GT-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 17, 2017 at 09:34:18AM +0100, Thomas Gleixner wrote:
> That's one thing, but OTOH we really can avoid the KERN_ERR level print out
> for the case where mce is not available (for whatever reasons: HW / Virt /
> command line ....).
> 
> The simple 2 liner I posted earlier in this thread does it nicely.

Well, I seem to remember at the time of this:

  9c15a24b038f ("x86/mce: Improve mcheck_init_device() error handling")

that I requested to have that error message there so that we *know* when
that function fails instead of trying to decipher "Hey, mcelog doesn't
start here" and wonder why.

But we can kill it just as well, especially as there's patch deprecating
/dev/mcelog floating around. We can reorg error messages in that
function later, if deemed necessary.

So sure.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86/mce: Fix initialization error warning Borislav Petkov <bp@alien8.de> - 2017-01-16 23:00 +0100
  Re: [PATCH] x86/mce: Fix initialization error warning Prarit Bhargava <prarit@redhat.com> - 2017-01-16 23:10 +0100
    Re: [PATCH] x86/mce: Fix initialization error warning Borislav Petkov <bp@alien8.de> - 2017-01-16 23:50 +0100
      Re: [PATCH] x86/mce: Fix initialization error warning Prarit Bhargava <prarit@redhat.com> - 2017-01-17 00:20 +0100
        Re: [PATCH] x86/mce: Fix initialization error warning Borislav Petkov <bp@alien8.de> - 2017-01-17 00:40 +0100
          Re: [PATCH] x86/mce: Fix initialization error warning Prarit Bhargava <prarit@redhat.com> - 2017-01-17 01:20 +0100
          Re: [PATCH] x86/mce: Fix initialization error warning Thomas Gleixner <tglx@linutronix.de> - 2017-01-17 09:40 +0100
            Re: [PATCH] x86/mce: Fix initialization error warning Thomas Gleixner <tglx@linutronix.de> - 2017-01-17 10:20 +0100
            Re: [PATCH] x86/mce: Fix initialization error warning Borislav Petkov <bp@alien8.de> - 2017-01-17 10:20 +0100

csiph-web