Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560169

Re: [PATCH tip/core/rcu 1/6] rcu: Abstract the dynticks momentary-idle operation

Show key headers only | View raw

On Mon, Jan 16, 2017 at 10:57:04AM -0800, Josh Triplett wrote:
> On Mon, Jan 16, 2017 at 03:22:39AM -0800, Paul E. McKenney wrote:
> > On Sun, Jan 15, 2017 at 11:39:51PM -0800, Josh Triplett wrote:
> > > On Sat, Jan 14, 2017 at 12:54:40AM -0800, Paul E. McKenney wrote:
> > > > This commit is the first step towards full abstraction of all accesses to
> > > > the ->dynticks counter, implementing the previously open-coded atomic add
> > > > of two in a new rcu_dynticks_momentary_idle() function.  This abstraction
> > > > will ease changes to the ->dynticks counter operation.
> > > > 
> > > > Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> > > 
> > > This change has an additional effect not documented in the commit
> > > message: it eliminates the smp_mb__before_atomic and
> > > smp_mb__after_atomic calls.  Can you please document that in the commit
> > > message, and explain why that doesn't cause a problem?
> > 
> > The trick is that the old code used the non-value-returning atomic_add(),
> > which does not imply ordering, hence the smp_mb__before_atomic() and
> > smp_mb__after_atomic() calls.  The new code uses atomic_add_return(),
> > which does return a value, and therefore implies full ordering in and
> > of itself.
> > 
> > How would you like me to proceed?
> 
> With the above explanation added to the commit message:
> 
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Done, thank you!

							Thanx, Paul

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH tip/core/rcu 0/6] Dynticks updates for 4.11 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-14 10:00 +0100
  [PATCH tip/core/rcu 3/6] rcu: Abstract dynticks extended quiescent state enter/exit operations "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-14 10:00 +0100
    Re: [PATCH tip/core/rcu 3/6] rcu: Abstract dynticks extended  quiescent state enter/exit operations Josh Triplett <josh@joshtriplett.org> - 2017-01-16 08:50 +0100
      Re: [PATCH tip/core/rcu 3/6] rcu: Abstract dynticks extended  quiescent state enter/exit operations "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-16 12:40 +0100
        Re: [PATCH tip/core/rcu 3/6] rcu: Abstract dynticks extended  quiescent state enter/exit operations Josh Triplett <josh@joshtriplett.org> - 2017-01-16 20:30 +0100
          Re: [PATCH tip/core/rcu 3/6] rcu: Abstract dynticks extended  quiescent state enter/exit operations "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-17 01:20 +0100
    Re: [PATCH tip/core/rcu 3/6] rcu: Abstract dynticks extended  quiescent state enter/exit operations Peter Zijlstra <peterz@infradead.org> - 2017-01-16 17:50 +0100
      Re: [PATCH tip/core/rcu 3/6] rcu: Abstract dynticks extended  quiescent state enter/exit operations "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-16 22:10 +0100
        Re: [PATCH tip/core/rcu 3/6] rcu: Abstract dynticks extended  quiescent state enter/exit operations "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-17 01:10 +0100
  [PATCH tip/core/rcu 4/6] rcu: Abstract extended quiescent state determination "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-14 10:00 +0100
  [PATCH tip/core/rcu 1/6] rcu: Abstract the dynticks momentary-idle operation "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-14 10:00 +0100
    Re: [PATCH tip/core/rcu 1/6] rcu: Abstract the dynticks  momentary-idle operation Josh Triplett <josh@joshtriplett.org> - 2017-01-16 08:50 +0100
      Re: [PATCH tip/core/rcu 1/6] rcu: Abstract the dynticks  momentary-idle operation "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-16 12:30 +0100
        Re: [PATCH tip/core/rcu 1/6] rcu: Abstract the dynticks  momentary-idle operation Josh Triplett <josh@joshtriplett.org> - 2017-01-16 20:00 +0100
          Re: [PATCH tip/core/rcu 1/6] rcu: Abstract the dynticks  momentary-idle operation "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-17 00:50 +0100
  Re: [PATCH tip/core/rcu 0/6] Dynticks updates for 4.11 Josh Triplett <josh@joshtriplett.org> - 2017-01-16 09:00 +0100
  Re: [PATCH tip/core/rcu 0/6] Dynticks updates for 4.11 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-18 03:50 +0100
    [PATCH v2 tip/core/rcu 3/6] rcu: Abstract dynticks extended quiescent state enter/exit operations "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-18 03:50 +0100
      Re: [PATCH v2 tip/core/rcu 3/6] rcu: Abstract dynticks extended  quiescent state enter/exit operations Josh Triplett <josh@joshtriplett.org> - 2017-01-21 21:50 +0100
        Re: [PATCH v2 tip/core/rcu 3/6] rcu: Abstract dynticks extended  quiescent state enter/exit operations "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-23 20:50 +0100
    Re: [PATCH v3 tip/core/rcu 0/6] Dynticks updates for 4.11 "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-24 22:50 +0100
      [PATCH v3 tip/core/rcu 4/6] rcu: Abstract extended quiescent state determination "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-24 22:50 +0100
      [PATCH v3 tip/core/rcu 1/6] rcu: Abstract the dynticks momentary-idle operation "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-01-24 22:50 +0100

csiph-web