[PATCH 3/4] ARCv2: smp: MCIP: remove debug aid to halt all cores when one halts

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.roellig-ltd.de!open-news-network.org!news.albasani.net!news.szaf.org!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Vineet Gupta <Vineet.Gupta1@synopsys.com>
Newsgroups	linux.kernel
Subject	[PATCH 3/4] ARCv2: smp: MCIP: remove debug aid to halt all cores when one halts
Date	Mon, 16 Jan 2017 22:00:02 +0100
Message-ID	<t0mxI-5SC-11@gated-at.bofh.it> (permalink)
References	<t0mxH-5SC-3@gated-at.bofh.it>
X-Original-To	<linux-snps-arc@lists.infradead.org>, <Alexey.Brodkin@synopsys.com>
X-Mailer	git-send-email 2.7.4
MIME-Version	1.0
Content-Type	text/plain
X-Originating-IP	[10.10.161.70]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	<linux-kernel@vger.kernel.org>, Vineet Gupta <Vineet.Gupta1@synopsys.com>
X-Original-Date	Mon, 16 Jan 2017 12:57:56 -0800
X-Original-Message-ID	<1484600277-32345-4-git-send-email-vgupta@synopsys.com>
X-Original-References	<1484600277-32345-1-git-send-email-vgupta@synopsys.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1560051

Show key headers only | View raw

This was really usefull when doing initial bringup and also for
occassional debug of software and hardware bugs. However in the new
smp-boot regime, non masters will "self" halt even for run-on-reset
configs. This will misinteract with the debug feature as in even master
will get halted when the non masters self halt.

Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
---
 arch/arc/kernel/mcip.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/arc/kernel/mcip.c b/arch/arc/kernel/mcip.c
index f39142acc89e..933382e0edd0 100644
--- a/arch/arc/kernel/mcip.c
+++ b/arch/arc/kernel/mcip.c
@@ -101,11 +101,6 @@ static void mcip_probe_n_setup(void)
 		IS_AVAIL1(mp.gfrc, "GFRC"));
 
 	cpuinfo_arc700[0].extn.gfrc = mp.gfrc;
-
-	if (mp.dbg) {
-		__mcip_cmd_data(CMD_DEBUG_SET_SELECT, 0, 0xf);
-		__mcip_cmd_data(CMD_DEBUG_SET_MASK, 0xf, 0xf);
-	}
 }
 
 struct plat_smp_ops plat_smp_ops = {
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] ARCv2: smp: MCIP: remove debug aid to halt all cores when one halts Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-01-16 22:00 +0100
  RE: [PATCH 3/4] ARCv2: smp: MCIP: remove debug aid to halt all  cores when one halts Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-01-17 21:20 +0100

csiph-web