Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559932

Re: [PATCH RFC v3 5/5] tpm2: expose resource manager via a device link /dev/tpms<n>

From Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH RFC v3 5/5] tpm2: expose resource manager via a device link /dev/tpms<n>
Date 2017-01-16 18:30 +0100
Message-ID <t0jgu-3vr-7@gated-at.bofh.it> (permalink)
References <t0fmx-Sv-5@gated-at.bofh.it> <t0fmy-Sv-23@gated-at.bofh.it> <t0iaJ-2OC-7@gated-at.bofh.it>
Organization Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Mon, Jan 16, 2017 at 09:14:13AM -0700, Jason Gunthorpe wrote:
> On Mon, Jan 16, 2017 at 03:12:11PM +0200, Jarkko Sakkinen wrote:
> 
> > @@ -199,7 +227,9 @@ struct tpm_chip *tpm_chip_alloc(struct device *pdev,
> >  	return chip;
> >  
> >  out:
> > +	put_device(&chip->devrm);
> >  	put_device(&chip->dev);
> > +	put_device(&chip->devrm);
> >  	return ERR_PTR(rc);
> >  }
> 
> Something has gone wrong here..

Not a big surprise. There were a bunch of these small patches
that I had to squash. Thanks for spotting this.

Funny that I didn't experiece any issues when I run my smoke
tests.

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC v3 0/5] RFC: in-kernel resource manager Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-16 14:20 +0100
  [PATCH RFC v3 3/5] tpm: infrastructure for TPM spaces Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-16 14:20 +0100
  [PATCH RFC v3 2/5] tpm: export tpm2_flush_context_cmd Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-16 14:20 +0100
  [PATCH RFC v3 4/5] tpm: split out tpm-dev.c into tpm-dev.c and tpm-common-dev.c Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-16 14:20 +0100
  [PATCH RFC v3 1/5] tpm: validate TPM 2.0 commands Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-16 14:20 +0100
  [PATCH RFC v3 5/5] tpm2: expose resource manager via a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-16 14:20 +0100
    Re: [PATCH RFC v3 5/5] tpm2: expose resource manager via a device  link /dev/tpms<n> Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-16 17:20 +0100
      Re: [PATCH RFC v3 5/5] tpm2: expose resource manager via a device  link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-16 18:30 +0100
        Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via a device link /dev/tpms<n> James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-16 18:30 +0100
          Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-17 08:20 +0100
    Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-18 16:10 +0100
      Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-19 12:00 +0100
        Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-19 13:30 +0100
          Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-20 14:40 +0100
            Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-20 22:10 +0100
              Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-21 20:30 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-22 16:00 +0100
              Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-21 21:50 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-22 16:00 +0100
              Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-22 18:50 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-22 19:50 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-22 21:40 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-22 22:10 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-22 22:40 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-23 15:10 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-23 17:20 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-24 13:10 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-23 18:00 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-23 22:50 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-23 23:20 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-25 14:50 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-25 14:50 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via a device link /dev/tpms<n> James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-27 03:00 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-27 07:50 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-25 21:30 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-22 22:10 +0100
                Re: [tpmdd-devel] [PATCH RFC v3 5/5] tpm2: expose resource manager  via    a device link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-22 21:30 +0100
    Re: [PATCH RFC v3 5/5] tpm2: expose resource manager via a device  link /dev/tpms<n> Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-19 11:50 +0100

csiph-web