Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559935

[PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device

Show all headers | View raw

Legacy RTC requires interrupt line 8 to be dedicated for it. On
Intel MID platforms the legacy PIC is absent and in order to make RTC
work we need to allocate interrupt separately.

Current solution brought by the commit

  82a51c38f199 ("x86/platform/intel-mid: Enable RTC on Intel Merrifield")

does it in a wrong place, and since it's done unconditionally for all
x86 devices, some of them, e.g. PNP based, might get it wrong -- at the
beginning x86_platform.legacy.rtc flag is set for all x86 devices.

Move interrupt allocation to arch/x86/kernel/rtc.c module and allocate
it for Intel MID platform devices only.

Fixes: 82a51c38f199 ("x86/platform/intel-mid: Enable RTC on Intel Merrifield")
Cc: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
- add headers and #ifdef to make kbuild bot happy
- re-test on PNP platform with acpi=off, thus, update patch accordingly

 arch/x86/kernel/rtc.c             | 21 +++++++++++++++++++++
 arch/x86/platform/intel-mid/sfi.c | 14 --------------
 2 files changed, 21 insertions(+), 14 deletions(-)

diff --git a/arch/x86/kernel/rtc.c b/arch/x86/kernel/rtc.c
index 5b21cb7d84d6..bf4cb88b9186 100644
--- a/arch/x86/kernel/rtc.c
+++ b/arch/x86/kernel/rtc.c
@@ -12,7 +12,9 @@
 #include <asm/vsyscall.h>
 #include <asm/x86_init.h>
 #include <asm/time.h>
+#include <asm/hw_irq.h>
 #include <asm/intel-mid.h>
+#include <asm/io_apic.h>
 #include <asm/setup.h>
 
 #ifdef CONFIG_X86_32
@@ -155,6 +157,20 @@ void read_persistent_clock(struct timespec *ts)
 	x86_platform.get_wallclock(ts);
 }
 
+#ifdef CONFIG_X86_IO_APIC
+static __init int allocate_rtc_cmos_irq(void)
+{
+	struct irq_alloc_info info;
+
+	if (!intel_mid_identify_cpu())
+	       return 0;
+
+	ioapic_set_alloc_attr(&info, NUMA_NO_NODE, 1, 0);
+	return mp_map_gsi_to_irq(RTC_IRQ, IOAPIC_MAP_ALLOC, &info);
+}
+#else
+static inline int allocate_rtc_cmos_irq(void) { return 0; }
+#endif
 
 static struct resource rtc_resources[] = {
 	[0] = {
@@ -178,6 +194,7 @@ static struct platform_device rtc_device = {
 
 static __init int add_rtc_cmos(void)
 {
+	int ret;
 #ifdef CONFIG_PNP
 	static const char * const ids[] __initconst =
 	    { "PNP0b00", "PNP0b01", "PNP0b02", };
@@ -197,6 +214,10 @@ static __init int add_rtc_cmos(void)
 	if (!x86_platform.legacy.rtc)
 		return -ENODEV;
 
+	ret = allocate_rtc_cmos_irq();
+	if (ret < 0)
+		return ret;
+
 	platform_device_register(&rtc_device);
 	dev_info(&rtc_device.dev,
 		 "registered platform RTC device (no PNP device found)\n");
diff --git a/arch/x86/platform/intel-mid/sfi.c b/arch/x86/platform/intel-mid/sfi.c
index e4d4cabbb370..19b43e3a9f0f 100644
--- a/arch/x86/platform/intel-mid/sfi.c
+++ b/arch/x86/platform/intel-mid/sfi.c
@@ -41,7 +41,6 @@
 #include <asm/intel_scu_ipc.h>
 #include <asm/apb_timer.h>
 #include <asm/reboot.h>
-#include <asm/time.h>
 
 #define	SFI_SIG_OEM0	"OEM0"
 #define MAX_IPCDEVS	24
@@ -540,21 +539,8 @@ static int __init sfi_parse_devs(struct sfi_table_header *table)
 	return 0;
 }
 
-static int __init intel_mid_legacy_rtc_init(void)
-{
-	struct irq_alloc_info info;
-
-	if (!x86_platform.legacy.rtc)
-		return -ENODEV;
-
-	ioapic_set_alloc_attr(&info, NUMA_NO_NODE, 1, 0);
-	return mp_map_gsi_to_irq(RTC_IRQ, IOAPIC_MAP_ALLOC, &info);
-}
-
 static int __init intel_mid_platform_init(void)
 {
-	intel_mid_legacy_rtc_init();
-
 	sfi_table_parse(SFI_SIG_GPIO, NULL, NULL, sfi_parse_gpio);
 	sfi_table_parse(SFI_SIG_DEVS, NULL, NULL, sfi_parse_devs);
 	return 0;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-16 18:30 +0100
  Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-01-16 20:10 +0100
    Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-16 20:30 +0100
      Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Thomas Gleixner <tglx@linutronix.de> - 2017-01-16 22:10 +0100
        Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-16 23:50 +0100
          Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Thomas Gleixner <tglx@linutronix.de> - 2017-01-17 09:50 +0100
        Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-17 14:50 +0100
          Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Thomas Gleixner <tglx@linutronix.de> - 2017-01-18 12:10 +0100
            Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-18 13:00 +0100
          Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-18 12:20 +0100
          Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Thomas Gleixner <tglx@linutronix.de> - 2017-01-18 12:50 +0100
            Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-18 17:40 +0100
              Re: [PATCH v2 1/1] x86/rtc: Allocate interrupt for platform device Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-18 18:00 +0100

csiph-web