Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1559571

Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check

From Borislav Petkov <bp@alien8.de>
Newsgroups linux.kernel
Subject Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check
Date 2017-01-16 11:00 +0100
Message-ID <t0cf0-71a-13@gated-at.bofh.it> (permalink)
References <t0bCi-6HI-19@gated-at.bofh.it> <t0bLY-6Q2-9@gated-at.bofh.it> <t0bVE-6TE-27@gated-at.bofh.it> <t0c5j-6Xo-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 16, 2017 at 11:48:51AM +0200, Leon Romanovsky wrote:
> Almost, except one point - pr_warn and dump_stack have different log

Actually, Michal pointed out on IRC a more relevant difference:

WARN() taints the kernel and we don't want that for GFP flags misuse.
Also, from looking at __warn(), it checks panic_on_warn and we explode
if set.

So no, we probably don't want WARN() here.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Borislav Petkov <bp@alien8.de> - 2017-01-16 10:20 +0100
  Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Leon Romanovsky <leon@kernel.org> - 2017-01-16 10:30 +0100
    Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Borislav Petkov <bp@alien8.de> - 2017-01-16 10:40 +0100
      Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Leon Romanovsky <leon@kernel.org> - 2017-01-16 10:50 +0100
        Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Michal Hocko <mhocko@kernel.org> - 2017-01-16 11:00 +0100
        Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Borislav Petkov <bp@alien8.de> - 2017-01-16 11:00 +0100
          Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Leon Romanovsky <leon@kernel.org> - 2017-01-16 11:20 +0100
            Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Leon Romanovsky <leon@kernel.org> - 2017-01-16 11:20 +0100
            Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Borislav Petkov <bp@alien8.de> - 2017-01-16 11:20 +0100
  Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Michal Hocko <mhocko@kernel.org> - 2017-01-16 10:40 +0100
  Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Vlastimil Babka <vbabka@suse.cz> - 2017-01-16 11:10 +0100

csiph-web