Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1561666

[PATCH 4.4 18/48] USB: serial: ch341: fix initial modem-control state

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject [PATCH 4.4 18/48] USB: serial: ch341: fix initial modem-control state
Date 2017-01-18 12:40 +0100
Message-ID <t0WKU-3x9-51@gated-at.bofh.it> (permalink)
References <t0VYt-2Rb-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


4.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Johan Hovold <johan@kernel.org>

commit 4e2da44691cffbfffb1535f478d19bc2dca3e62b upstream.

DTR and RTS will be asserted by the tty-layer when the port is opened
and deasserted on close (if HUPCL is set). Make sure the initial state
is not-asserted before the port is first opened as well.

Fixes: 664d5df92e88 ("USB: usb-serial ch341: support for DTR/RTS/CTS")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/serial/ch341.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/usb/serial/ch341.c
+++ b/drivers/usb/serial/ch341.c
@@ -253,7 +253,6 @@ static int ch341_port_probe(struct usb_s
 
 	spin_lock_init(&priv->lock);
 	priv->baud_rate = DEFAULT_BAUD_RATE;
-	priv->line_control = CH341_BIT_RTS | CH341_BIT_DTR;
 
 	r = ch341_configure(port->serial->dev, priv);
 	if (r < 0)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 4.4 00/48] 4.4.44-stable review Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-18 12:40 +0100
  [PATCH 4.4 18/48] USB: serial: ch341: fix initial modem-control state Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-18 12:40 +0100
  Re: [PATCH 4.4 00/48] 4.4.44-stable review Guenter Roeck <linux@roeck-us.net> - 2017-01-18 20:20 +0100
  Re: [PATCH 4.4 00/48] 4.4.44-stable review Shuah Khan <shuah.kh@samsung.com> - 2017-01-19 19:40 +0100

csiph-web