[PATCH] platform/x86: surface3-wmi: fix uninitialized symbol

From	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH] platform/x86: surface3-wmi: fix uninitialized symbol
Date	2017-01-18 09:40 +0100
Message-ID	<t0TWF-1HC-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The patch 3dda3b3798f9: "platform/x86: Add custom surface3 platform
device for controlling LID" from Nov 25, 2016, leads to the following
static checker warning:

        drivers/platform/x86/surface3-wmi.c:168 s3_wmi_check_platform_device()
        error: uninitialized symbol 'ts_adev'.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---

Hi Dan,

Sorry for the lag in treating this simple defect.

Cheers,
Benjamin

 drivers/platform/x86/surface3-wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/surface3-wmi.c b/drivers/platform/x86/surface3-wmi.c
index cbf4d83..676cfca 100644
--- a/drivers/platform/x86/surface3-wmi.c
+++ b/drivers/platform/x86/surface3-wmi.c
@@ -139,7 +139,7 @@ static acpi_status s3_wmi_attach_spi_device(acpi_handle handle,
 
 static int s3_wmi_check_platform_device(struct device *dev, void *data)
 {
-	struct acpi_device *adev, *ts_adev;
+	struct acpi_device *adev, *ts_adev = NULL;
 	acpi_handle handle;
 	acpi_status status;
 
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] platform/x86: surface3-wmi: fix uninitialized symbol Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-01-18 09:40 +0100
  Re: [PATCH] platform/x86: surface3-wmi: fix uninitialized symbol Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-18 20:10 +0100

csiph-web