Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1561326

Re: [RFC 4/4] mm, page_alloc: fix premature OOM when racing with cpuset mems update

From "Hillf Danton" <hillf.zj@alibaba-inc.com>
Newsgroups linux.kernel
Subject Re: [RFC 4/4] mm, page_alloc: fix premature OOM when racing with cpuset mems update
Date 2017-01-18 08:20 +0100
Message-ID <t0SHf-13d-5@gated-at.bofh.it> (permalink)
References <t0LZ8-5nf-33@gated-at.bofh.it> <t0LZ8-5nf-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wednesday, January 18, 2017 6:16 AM Vlastimil Babka wrote: 
> 
> @@ -3802,13 +3811,8 @@ __alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order,
>  	 * Also recalculate the starting point for the zonelist iterator or
>  	 * we could end up iterating over non-eligible zones endlessly.
>  	 */
Is the newly added comment still needed?

> -	if (unlikely(ac.nodemask != nodemask)) {
> -no_zone:
> +	if (unlikely(ac.nodemask != nodemask))
>  		ac.nodemask = nodemask;
> -		ac.preferred_zoneref = first_zones_zonelist(ac.zonelist,
> -						ac.high_zoneidx, ac.nodemask);
> -		/* If we have NULL preferred zone, slowpath wll handle that */
> -	}
> 
>  	page = __alloc_pages_slowpath(alloc_mask, order, &ac);
> 
> --
> 2.11.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC 0/4] fix premature OOM due to cpuset races Vlastimil Babka <vbabka@suse.cz> - 2017-01-18 01:10 +0100
  [RFC 4/4] mm, page_alloc: fix premature OOM when racing with cpuset mems update Vlastimil Babka <vbabka@suse.cz> - 2017-01-18 01:10 +0100
    Re: [RFC 4/4] mm, page_alloc: fix premature OOM when racing with cpuset mems update "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-01-18 08:20 +0100
      Re: [RFC 4/4] mm, page_alloc: fix premature OOM when racing with  cpuset mems update Vlastimil Babka <vbabka@suse.cz> - 2017-01-18 10:40 +0100
    Re: [RFC 4/4] mm, page_alloc: fix premature OOM when racing with  cpuset mems update Mel Gorman <mgorman@techsingularity.net> - 2017-01-18 11:20 +0100
  [RFC 3/4] mm, page_alloc: move cpuset seqcount checking to slowpath Vlastimil Babka <vbabka@suse.cz> - 2017-01-18 01:20 +0100
    Re: [RFC 3/4] mm, page_alloc: move cpuset seqcount checking to slowpath "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-01-18 08:40 +0100
      Re: [RFC 3/4] mm, page_alloc: move cpuset seqcount checking to  slowpath Vlastimil Babka <vbabka@suse.cz> - 2017-01-18 10:30 +0100
    Re: [RFC 3/4] mm, page_alloc: move cpuset seqcount checking to  slowpath Mel Gorman <mgorman@techsingularity.net> - 2017-01-18 11:10 +0100
    Re: [RFC 3/4] mm, page_alloc: move cpuset seqcount checking to  slowpath Michal Hocko <mhocko@kernel.org> - 2017-01-18 11:10 +0100
      Re: [RFC 3/4] mm, page_alloc: move cpuset seqcount checking to  slowpath Vlastimil Babka <vbabka@suse.cz> - 2017-01-18 11:10 +0100
        Re: [RFC 3/4] mm, page_alloc: move cpuset seqcount checking to  slowpath Michal Hocko <mhocko@kernel.org> - 2017-01-18 11:20 +0100
  [RFC 2/4] mm, page_alloc: fix fast-path race with cpuset update or removal Vlastimil Babka <vbabka@suse.cz> - 2017-01-18 01:20 +0100
    Re: [RFC 2/4] mm, page_alloc: fix fast-path race with cpuset update  or removal Michal Hocko <mhocko@kernel.org> - 2017-01-18 10:40 +0100
    Re: [RFC 2/4] mm, page_alloc: fix fast-path race with cpuset update  or removal Mel Gorman <mgorman@techsingularity.net> - 2017-01-18 10:50 +0100
  Re: [RFC 0/4] fix premature OOM due to cpuset races Michal Hocko <mhocko@kernel.org> - 2017-01-18 10:40 +0100
  [RFC 5/4] mm, page_alloc: fix premature OOM due to vma mempolicy  update Vlastimil Babka <vbabka@suse.cz> - 2017-01-18 17:30 +0100
    Re: [RFC 5/4] mm, page_alloc: fix premature OOM due to vma mempolicy  update Vlastimil Babka <vbabka@suse.cz> - 2017-01-18 17:30 +0100

csiph-web