Re: [PATCH] clk: rockchip: fix the incorrect pclk_edp div width for RK3399

From	hl <hl@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: rockchip: fix the incorrect pclk_edp div width for RK3399
Date	2017-01-18 05:30 +0100
Message-ID	<t0Q2J-7Ky-1@gated-at.bofh.it> (permalink)
References	<t0Q2J-7Ky-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Tested-by: Lin Huang <hl@rock-chips.com>

On 2017年01月18日 12:20, Xing Zheng wrote:
> The range of the  pclk_edp_div_con is [13:8] and 6 bits, not 5.
>
> Reported-by: Lin Huang <hl@rock-chips.com>
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> ---
>
>   drivers/clk/rockchip/clk-rk3399.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
> index 3490887..73121b14 100644
> --- a/drivers/clk/rockchip/clk-rk3399.c
> +++ b/drivers/clk/rockchip/clk-rk3399.c
> @@ -1132,7 +1132,7 @@ static struct rockchip_clk_branch rk3399_clk_branches[] __initdata = {
>   			RK3399_CLKGATE_CON(11), 8, GFLAGS),
>   
>   	COMPOSITE(PCLK_EDP, "pclk_edp", mux_pll_src_cpll_gpll_p, 0,
> -			RK3399_CLKSEL_CON(44), 15, 1, MFLAGS, 8, 5, DFLAGS,
> +			RK3399_CLKSEL_CON(44), 15, 1, MFLAGS, 8, 6, DFLAGS,
>   			RK3399_CLKGATE_CON(11), 11, GFLAGS),
>   	GATE(PCLK_EDP_NOC, "pclk_edp_noc", "pclk_edp", CLK_IGNORE_UNUSED,
>   			RK3399_CLKGATE_CON(32), 12, GFLAGS),

-- 
Lin Huang

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] clk: rockchip: fix the incorrect pclk_edp div width for  RK3399 hl <hl@rock-chips.com> - 2017-01-18 05:30 +0100

csiph-web