Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1561068

Re: [patch] block: add blktrace C events for bio-based drivers

Show key headers only | View raw

Jens Axboe <axboe@kernel.dk> writes:

> On 01/17/2017 01:57 PM, Jeff Moyer wrote:
>> Only a few bio-based drivers actually generate blktrace completion
>> (C) events.  Instead of changing all bio-based drivers to call
>> trace_block_bio_complete, move the tracing to bio_complete, and remove
>> the explicit tracing from the few drivers that actually do it.  After
>> this patch, there is exactly one caller of trace_block_bio_complete
>> and one caller of trace_block_rq_complete.  More importantly, all
>> bio-based drivers now generate C events, which is useful for
>> performance analysis.
>
> I like the change, hate the naming. I'd prefer one of two things:
>
> - Add bio_endio_complete() instead. That name sucks too, the
>   important part is flipping the __name() to have a trace
>   version instead.

I had also considered bio_endio_notrace().

> - Mark the bio as trace completed, and keep the naming. Since
>   it's only off the completion path, that can be just marking
>   the bi_flags non-atomically.
>
> I probably prefer the latter.

Hmm, okay.  I'll take a crack at that.

Thanks!
Jeff

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch] block: add blktrace C events for bio-based drivers Jeff Moyer <jmoyer@redhat.com> - 2017-01-17 23:00 +0100
  Re: [patch] block: add blktrace C events for bio-based drivers Jens Axboe <axboe@kernel.dk> - 2017-01-17 23:10 +0100
    Re: [patch] block: add blktrace C events for bio-based drivers Jeff Moyer <jmoyer@redhat.com> - 2017-01-17 23:40 +0100
    Re: [patch] block: add blktrace C events for bio-based drivers Jeff Moyer <jmoyer@redhat.com> - 2017-01-18 17:10 +0100

csiph-web