Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1560945

Re: [PATCH] stmmac: add missing of_node_put

Show all headers | View raw

From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Tue, 17 Jan 2017 12:23:21 +0100

> The function stmmac_dt_phy provides several possibilities for initializing
> plat->mdio_node, all of which have the effect of increasing the reference
> count of the assigned value.  This field is not updated elsewhere, so the
> value is live until the end of the lifetime of plat (devm_allocated), just
> after the end of stmmac_remove_config_dt.  Thus, add an of_node_put on
> plat->mdio_node in stmmac_remove_config_dt.  It is possible that the field
> mdio_node is never initialized, but of_node_put is NULL-safe, so it is also
> safe to call of_node_put in that case.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Applied, thanks Julia.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] stmmac: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2017-01-17 12:50 +0100
  Re: [PATCH] stmmac: add missing of_node_put Alexandre Torgue <alexandre.torgue@st.com> - 2017-01-17 15:40 +0100
  Re: [PATCH] stmmac: add missing of_node_put David Miller <davem@davemloft.net> - 2017-01-17 20:20 +0100

csiph-web